Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: tools/perf/benchmarks/memory.py

Issue 2649043007: Updating memory.top_10_mobile benchmark to stop ignoring max, std, and count. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/memory.py
diff --git a/tools/perf/benchmarks/memory.py b/tools/perf/benchmarks/memory.py
index b0eafacd7d72391ae634b955d433800967d4f0de..491625f9713c5cdd878b6ecad64897d662c3a3c8 100644
--- a/tools/perf/benchmarks/memory.py
+++ b/tools/perf/benchmarks/memory.py
@@ -18,6 +18,8 @@ import page_sets
# https://github.com/catapult-project/catapult/blob/master/tracing/tracing/value/numeric.html#L323
_IGNORED_STATS_RE = re.compile(
r'(?<!dump)(?<!process)_(std|count|max|min|sum|pct_\d{4}(_\d+)?)$')
+_IGNORED_TOP_10_STATS_RE = re.compile(
+ r'(?<!dump)(?<!process)_(min|sum|pct_\d{4}(_\d+)?)$')
class _MemoryInfra(perf_benchmark.PerfBenchmark):
@@ -81,7 +83,7 @@ class MemoryBenchmarkTop10Mobile(_MemoryInfra):
def ValueCanBeAddedPredicate(cls, value, is_first_result):
# TODO(crbug.com/610962): Remove this stopgap when the perf dashboard
# is able to cope with the data load generated by TBMv2 metrics.
- return not _IGNORED_STATS_RE.search(value.name)
+ return not _IGNORED_TOP_10_STATS_RE.search(value.name)
class MemoryBenchmarkTop10MobileStress(MemoryBenchmarkTop10Mobile):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698