Record whether a file picker specialized for media content can be used

ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.ui.base;
 
 import android.Manifest;
 import android.annotation.TargetApi;
 import android.app.Activity;
 import android.content.ClipData;
 import android.content.ContentResolver;
 import android.content.Context;
 import android.content.Intent;
 import android.content.pm.PackageManager;
 import android.net.Uri;
 import android.os.AsyncTask;
 import android.os.Build;
 import android.provider.MediaStore;
 import android.text.TextUtils;
 import android.util.Log;
 
 import org.chromium.base.ApiCompatibilityUtils;
 import org.chromium.base.ContentUriUtils;
 import org.chromium.base.ContextUtils;
 import org.chromium.base.ThreadUtils;
 import org.chromium.base.VisibleForTesting;
 import org.chromium.base.annotations.CalledByNative;
 import org.chromium.base.annotations.JNINamespace;
 import org.chromium.base.annotations.MainDex;
+import org.chromium.base.metrics.RecordHistogram;
 import org.chromium.ui.R;
 import org.chromium.ui.UiUtils;
 
 import java.io.File;
 import java.io.IOException;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.List;
 
 /**
  * A dialog that is triggered from a file input field that allows a user to select a file based on
  * a set of accepted file types. The path of the selected file is passed to the native dialog.
  */
 @JNINamespace("ui")
 @MainDex
 public class SelectFileDialog
         implements WindowAndroid.IntentCallback, WindowAndroid.PermissionCallback {
     private static final String TAG = "SelectFileDialog";
     private static final String IMAGE_TYPE = "image/";
     private static final String VIDEO_TYPE = "video/";
     private static final String AUDIO_TYPE = "audio/";
     private static final String ALL_IMAGE_TYPES = IMAGE_TYPE + "*";
     private static final String ALL_VIDEO_TYPES = VIDEO_TYPE + "*";
     private static final String ALL_AUDIO_TYPES = AUDIO_TYPE + "*";
     private static final String ANY_TYPES = "*/*";
 
     /**
+     * The SELECT_FILE_DIALOG_SCOPE_* enumerations are used to measure the sort of content that
+     * developers are requesting to be shown in the select file dialog. Values must be kept in sync
+     * with their definition in //tools/metrics/histograms/histograms.xml.
+     */
+    private static final int SELECT_FILE_DIALOG_SCOPE_GENERIC = 0;
+    private static final int SELECT_FILE_DIALOG_SCOPE_IMAGES = 1;
+    private static final int SELECT_FILE_DIALOG_SCOPE_IMAGES_AND_VIDEO = 2;
+    private static final int SELECT_FILE_DIALOG_SCOPE_MAX =
+            SELECT_FILE_DIALOG_SCOPE_IMAGES_AND_VIDEO;
+
+    /**
      * If set, overrides the WindowAndroid passed in {@link selectFile()}.
      */
     private static WindowAndroid sOverrideWindowAndroid;
 
     private final long mNativeSelectFileDialog;
     private List<String> mFileTypes;
     private boolean mCapture;
     private boolean mAllowMultiple;
     private Uri mCameraOutputUri;
     private WindowAndroid mWindowAndroid;
@@ skipping 100 matching lines @@
         } else if (captureMicrophone() && soundRecorder != null) {
             if (mWindowAndroid.showIntent(soundRecorder, this, R.string.low_memory_error)) return;
         }
 
         Intent getContentIntent = new Intent(Intent.ACTION_GET_CONTENT);
 
         if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN_MR2 && mAllowMultiple) {
             getContentIntent.putExtra(Intent.EXTRA_ALLOW_MULTIPLE, true);
         }
 
+        RecordHistogram.recordEnumeratedHistogram("Android.SelectFileDialogScope",
+                determineSelectFileDialogScope(), SELECT_FILE_DIALOG_SCOPE_MAX);
+
         ArrayList<Intent> extraIntents = new ArrayList<Intent>();
         if (!noSpecificType()) {
             // Create a chooser based on the accept type that was specified in the webpage. Note
             // that if the web page specified multiple accept types, we will have built a generic
             // chooser above.
             if (shouldShowImageTypes()) {
                 if (camera != null) extraIntents.add(camera);
                 getContentIntent.setType(ALL_IMAGE_TYPES);
             } else if (shouldShowVideoTypes()) {
                 if (camcorder != null) extraIntents.add(camcorder);
@@ skipping 161 matching lines @@
                 return;
             }
         }
         launchSelectFileIntent();
     }
 
     private void onFileNotSelected() {
         nativeOnFileNotSelected(mNativeSelectFileDialog);
     }
 
+    // Determines the scope of the requested select file dialog for use in a UMA histogram. Right
+    // now we want to distinguish between generic, photo and visual media pickers.
+    private int determineSelectFileDialogScope() {

[Miguel Garcia, 2017/01/24 18:42:26]

So this will log as generic when asking for just video files?
(shouldShowImageTypes = false) ?
It will also log as generic when we want images + videos + audio.

+        if (!noSpecificType() && !shouldShowAudioTypes() && shouldShowImageTypes()) {
+            if (shouldShowVideoTypes()) {
+                return SELECT_FILE_DIALOG_SCOPE_IMAGES_AND_VIDEO;
+            } else {
+                return SELECT_FILE_DIALOG_SCOPE_IMAGES;
+            }
+        }
+
+        return SELECT_FILE_DIALOG_SCOPE_GENERIC;
+    }
+
     private boolean noSpecificType() {
         // We use a single Intent to decide the type of the file chooser we display to the user,
         // which means we can only give it a single type. If there are multiple accept types
         // specified, we will fallback to a generic chooser (unless a capture parameter has been
         // specified, in which case we'll try to satisfy that first.
         return mFileTypes.size() != 1 || mFileTypes.contains(ANY_TYPES);
     }
 
     private boolean shouldShowTypes(String allTypes, String specificType) {
         if (noSpecificType() || mFileTypes.contains(allTypes)) return true;
@@ skipping 89 matching lines @@
     private static SelectFileDialog create(long nativeSelectFileDialog) {
         return new SelectFileDialog(nativeSelectFileDialog);
     }
 
     private native void nativeOnFileSelected(long nativeSelectFileDialogImpl,
             String filePath, String displayName);
     private native void nativeOnMultipleFilesSelected(long nativeSelectFileDialogImpl,
             String[] filePathArray, String[] displayNameArray);
     private native void nativeOnFileNotSelected(long nativeSelectFileDialogImpl);
 }