Issue 264903004: Support 8bpp screens in X11

Issue 264903004: Support 8bpp screens in X11 (Closed)

Created:
6 years, 7 months ago by jbauman

Modified:
6 years, 7 months ago

Reviewers:
sadrul, piman

CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Support 8bpp screens in X11 Use Xrender to do the color conversion to 8bpp. BUG=368425 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267950

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -0 lines)			Patch
M	content/browser/compositor/software_output_device_x11.cc	View		2 chunks	+66 lines, -0 lines	0 comments	Download
M	ui/base/x/x11_util.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	ui/base/x/x11_util.cc	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

jbauman

This code was basically extracted (and simplified) from BackingStoreGtk.

6 years, 7 months ago (2014-05-01 23:04:39 UTC) #1

sadrul

LGTM with the nit: https://codereview.chromium.org/264903004/diff/1/ui/base/x/x11_util.cc File ui/base/x/x11_util.cc (right): https://codereview.chromium.org/264903004/diff/1/ui/base/x/x11_util.cc#newcode313 ui/base/x/x11_util.cc:313: render_supported = XRenderQueryExtension(dpy, &dummy, &dummy); ...

6 years, 7 months ago (2014-05-02 01:35:45 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/264903004/20001

6 years, 7 months ago (2014-05-02 19:13:32 UTC) #5

Message was sent while issue was closed.

Change committed as 267950

Expand Messages | Collapse Messages