Issue 26490004: Fix ninja wrapper script on non-x86 linux.

Issue 26490004: Fix ninja wrapper script on non-x86 linux. (Closed)

Created:
7 years, 2 months ago by Sam Clegg

Modified:
7 years, 2 months ago

Reviewers:
Nico, M-A Ruel

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org, Lei Zhang

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Visibility:
Public.

More Reviews

Description

Fix ninja wrapper script on non-x86 linux. The script would previously attempt to run the x86_32 version of ninja on 32-bit arches such as mips and arm rather than display the error message. This error showed up an ARM builder: /mnt/data/b/depot_tools/ninja: line 25: /mnt/data/b/depot_tools/ninja-linux32: cannot execute binary file Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=227549

Patch Set 1 : #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -5 lines)			Patch
	M	ninja	View	1 2	1 chunk	+11 lines, -5 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

Nico

lgtm https://codereview.chromium.org/26490004/diff/2001/ninja File ninja (right): https://codereview.chromium.org/26490004/diff/2001/ninja#newcode25 ninja:25: i686|x86_64) i*86?

7 years, 2 months ago (2013-10-08 16:24:08 UTC) #2

Lei Zhang

https://codereview.chromium.org/26490004/diff/2001/ninja File ninja (right): https://codereview.chromium.org/26490004/diff/2001/ninja#newcode29 ninja:29: # x86_64 hardware. nit: s/hardware/kernel/

7 years, 2 months ago (2013-10-08 16:27:57 UTC) #3

Sam Clegg

https://codereview.chromium.org/26490004/diff/2001/ninja File ninja (right): https://codereview.chromium.org/26490004/diff/2001/ninja#newcode25 ninja:25: i686|x86_64) On 2013/10/08 16:24:09, Nico wrote: > i*86? Done. ...

7 years, 2 months ago (2013-10-08 18:21:49 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sbc@chromium.org/26490004/11001

7 years, 2 months ago (2013-10-08 18:24:22 UTC) #5

commit-bot: I haz the power

Presubmit check for 26490004-11001 failed and returned exit status 1. Running presubmit commit checks ...

7 years, 2 months ago (2013-10-08 18:26:19 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sbc@chromium.org/26490004/11001

7 years, 2 months ago (2013-10-08 18:28:07 UTC) #8

Message was sent while issue was closed.

Change committed as 227549

Expand Messages | Collapse Messages