Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: ios/chrome/common/physical_web/physical_web_scanner.h

Issue 2648973004: Remove GetMetadata from PhysicalWebDataSource and PhysicalWebScanner (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/common/physical_web/physical_web_scanner.h
diff --git a/ios/chrome/common/physical_web/physical_web_scanner.h b/ios/chrome/common/physical_web/physical_web_scanner.h
index 354fdfc9c9cfd361b2ef71bd80d5700bf7ffe6f1..47b10065ff285f021a980de5664f3903038d7285 100644
--- a/ios/chrome/common/physical_web/physical_web_scanner.h
+++ b/ios/chrome/common/physical_web/physical_web_scanner.h
@@ -10,10 +10,6 @@
#include <memory>
#include <vector>
-namespace base {
-class ListValue;
-}
-
namespace physical_web {
struct Metadata;
using MetadataList = std::vector<Metadata>;
@@ -61,11 +57,6 @@ using MetadataList = std::vector<Metadata>;
// Returns the metadata for all resolved physical web URLs. The returned value
// will never be nil; if no metadata has been received then an empty list is
sdefresne 2017/01/24 09:54:38 nit: nil -> null (since this is a C++ smart pointe
mattreynolds 2017/01/24 19:11:44 Done.
// returned.
-- (std::unique_ptr<base::ListValue>)metadata;
-
-// Returns the metadata for all resolved physical web URLs. The returned value
-// will never be nil; if no metadata has been received then an empty list is
-// returned.
- (std::unique_ptr<physical_web::MetadataList>)metadataList;
@end

Powered by Google App Engine
This is Rietveld 408576698