Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: media/capture/video/linux/video_capture_device_factory_linux.cc

Issue 2648973003: Sort camera device list to use front camera first (Closed)
Patch Set: add comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/capture/video/video_capture_device_descriptor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/capture/video/linux/video_capture_device_factory_linux.cc
diff --git a/media/capture/video/linux/video_capture_device_factory_linux.cc b/media/capture/video/linux/video_capture_device_factory_linux.cc
index 14a1ca12e6b4c5679e1ed4efd5fc3df4b9aae3a2..970efdd6f5c36618768b378142065037edfb6fc4 100644
--- a/media/capture/video/linux/video_capture_device_factory_linux.cc
+++ b/media/capture/video/linux/video_capture_device_factory_linux.cc
@@ -228,6 +228,10 @@ void VideoCaptureDeviceFactoryLinux::GetDeviceDescriptors(
#endif
}
}
+ // Since JS doesn't have API to get camera facing, we sort the list to make
+ // apps can use the front camera by default.
+ // TODO(henryhsu): remove this after JS API completed.
mcasas 2017/01/23 16:46:59 Add here the https://crbug.com/ appropriate number
henryhsu 2017/01/24 03:14:31 Done.
+ std::sort(device_descriptors->begin(), device_descriptors->end());
}
void VideoCaptureDeviceFactoryLinux::GetSupportedFormats(
« no previous file with comments | « no previous file | media/capture/video/video_capture_device_descriptor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698