Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1023)

Unified Diff: media/capture/video/linux/video_capture_device_factory_linux.cc

Issue 2648973003: Sort camera device list to use front camera first (Closed)
Patch Set: address comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/capture/video/linux/video_capture_device_factory_linux.cc
diff --git a/media/capture/video/linux/video_capture_device_factory_linux.cc b/media/capture/video/linux/video_capture_device_factory_linux.cc
index 14a1ca12e6b4c5679e1ed4efd5fc3df4b9aae3a2..2bf09872467c6663397bedb1fd9dcbe1e380b23f 100644
--- a/media/capture/video/linux/video_capture_device_factory_linux.cc
+++ b/media/capture/video/linux/video_capture_device_factory_linux.cc
@@ -228,6 +228,12 @@ void VideoCaptureDeviceFactoryLinux::GetDeviceDescriptors(
#endif
}
}
+#if defined(OS_CHROMEOS)
+ // Since JS doesn't have API to get camera facing, we sort the list to make
+ // apps can use the front camera by default.
mcasas 2017/01/25 17:35:15 nit: s/to make apps can use/to make sure apps use/
henryhsu 2017/01/26 02:22:54 Done.
+ // TODO(henryhsu): remove this after JS API completed (crbug.com/543997).
Guido Urdaneta 2017/01/25 10:24:47 Is this comment valid? It is true that once crbug.
henryhsu 2017/01/25 10:38:01 Once crbug.com/543997 is fixed, caller should have
+ std::sort(device_descriptors->begin(), device_descriptors->end());
+#endif
}
void VideoCaptureDeviceFactoryLinux::GetSupportedFormats(

Powered by Google App Engine
This is Rietveld 408576698