Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Unified Diff: src/inspector/v8-stack-trace-impl.h

Issue 2648873002: [inspector] added creation frame for async call chains for promises (Closed)
Patch Set: merge async call chains onle when they have the same description Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/inspector/v8-stack-trace-impl.h
diff --git a/src/inspector/v8-stack-trace-impl.h b/src/inspector/v8-stack-trace-impl.h
index f0a452e9390dd8dccbbdadac41103dfeae4b32ad..f9313a4efcd972101ca1625c7734ff0f27dbd2b7 100644
--- a/src/inspector/v8-stack-trace-impl.h
+++ b/src/inspector/v8-stack-trace-impl.h
@@ -81,15 +81,21 @@ class V8StackTraceImpl final : public V8StackTrace {
const override;
std::unique_ptr<StringBuffer> toString() const override;
+ void setCreation(std::unique_ptr<V8StackTraceImpl> creation) {
dgozman 2017/01/24 23:57:44 Move definition to implementation file.
kozy 2017/01/25 00:45:43 Done.
+ m_creation = std::move(creation);
+ }
+
private:
V8StackTraceImpl(int contextGroupId, const String16& description,
std::vector<Frame>& frames,
- std::unique_ptr<V8StackTraceImpl> parent);
+ std::unique_ptr<V8StackTraceImpl> parent,
+ std::unique_ptr<V8StackTraceImpl> creation);
dgozman 2017/01/24 23:57:44 If you have a setter, don't pass in constructor.
kozy 2017/01/25 00:45:43 Done.
int m_contextGroupId;
String16 m_description;
std::vector<Frame> m_frames;
std::unique_ptr<V8StackTraceImpl> m_parent;
+ std::unique_ptr<V8StackTraceImpl> m_creation;
DISALLOW_COPY_AND_ASSIGN(V8StackTraceImpl);
};

Powered by Google App Engine
This is Rietveld 408576698