Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Unified Diff: src/inspector/v8-stack-trace-impl.h

Issue 2648873002: [inspector] added creation frame for async call chains for promises (Closed)
Patch Set: fixed usage of external reference Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/inspector/v8-stack-trace-impl.h
diff --git a/src/inspector/v8-stack-trace-impl.h b/src/inspector/v8-stack-trace-impl.h
index f0a452e9390dd8dccbbdadac41103dfeae4b32ad..e0b3e3f0cc870a590e4cda53a82247c877902091 100644
--- a/src/inspector/v8-stack-trace-impl.h
+++ b/src/inspector/v8-stack-trace-impl.h
@@ -56,10 +56,12 @@ class V8StackTraceImpl final : public V8StackTrace {
bool capture);
static std::unique_ptr<V8StackTraceImpl> create(
V8Debugger*, int contextGroupId, v8::Local<v8::StackTrace>,
- size_t maxStackSize, const String16& description = String16());
+ size_t maxStackSize, const String16& description = String16(),
+ std::unique_ptr<V8StackTraceImpl> creationStackTrace = nullptr);
static std::unique_ptr<V8StackTraceImpl> capture(
V8Debugger*, int contextGroupId, size_t maxStackSize,
- const String16& description = String16());
+ const String16& description = String16(),
+ std::unique_ptr<V8StackTraceImpl> creationStackTrace = nullptr);
// This method drops the async chain. Use cloneImpl() instead.
std::unique_ptr<V8StackTrace> clone() override;
@@ -84,12 +86,14 @@ class V8StackTraceImpl final : public V8StackTrace {
private:
V8StackTraceImpl(int contextGroupId, const String16& description,
std::vector<Frame>& frames,
- std::unique_ptr<V8StackTraceImpl> parent);
+ std::unique_ptr<V8StackTraceImpl> parent,
+ std::unique_ptr<V8StackTraceImpl> creation);
int m_contextGroupId;
String16 m_description;
std::vector<Frame> m_frames;
std::unique_ptr<V8StackTraceImpl> m_parent;
+ std::unique_ptr<V8StackTraceImpl> m_creation;
DISALLOW_COPY_AND_ASSIGN(V8StackTraceImpl);
};

Powered by Google App Engine
This is Rietveld 408576698