Issue 2648863002: Fix for covariant

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2648863002: Fix for covariant (Closed)

Created:
3 years, 11 months ago by vsm

Modified:
3 years, 11 months ago

Reviewers:
Leaf, Jacob

CC:
dev-compiler+reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Fix for covariant We've been silently failing to rebuild the SDK since covariant was added. Looking at making SDK build break fail the presubmit! TBR=leafp@google.com,jacobr@google.com Committed: https://github.com/dart-lang/sdk/commit/a7f7a311c052e31049aed1bd55f23f3ee4449f73

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+92 lines, -91 lines)			Patch
M	pkg/dev_compiler/lib/js/amd/dart_sdk.js	View	7 chunks	+18 lines, -18 lines	0 comments	Download
M	pkg/dev_compiler/lib/js/common/dart_sdk.js	View	7 chunks	+18 lines, -18 lines	0 comments	Download
M	pkg/dev_compiler/lib/js/es6/dart_sdk.js	View	7 chunks	+18 lines, -18 lines	0 comments	Download
M	pkg/dev_compiler/lib/js/legacy/dart_sdk.js	View	7 chunks	+18 lines, -18 lines	0 comments	Download
M	pkg/dev_compiler/lib/sdk/ddc_sdk.sum	View	Binary file		0 comments	Download
M	pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/types.dart	View	10 chunks	+19 lines, -19 lines	0 comments	Download
M	pkg/dev_compiler/tool/sdk_expected_errors.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 3 (1 generated)

vsm

Committed patchset #1 (id:1) manually as a7f7a311c052e31049aed1bd55f23f3ee4449f73 (presubmit successful).

3 years, 11 months ago (2017-01-20 23:20:54 UTC) #2

Message was sent while issue was closed.

lgtm