Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Unified Diff: third_party/WebKit/Source/devtools/front_end/data_grid/ViewportDataGrid.js

Issue 2648853002: [Devtools] Handle network sorting of grouped nodes properly (Closed)
Patch Set: Merge branch 'master' into GROUP_SORTING Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/data_grid/ViewportDataGrid.js
diff --git a/third_party/WebKit/Source/devtools/front_end/data_grid/ViewportDataGrid.js b/third_party/WebKit/Source/devtools/front_end/data_grid/ViewportDataGrid.js
index 200c37a2bf07434eacc3a478873adcd3bb768e23..581eba91e5ce3e7aed5a86b8fcad00cf9106e6e1 100644
--- a/third_party/WebKit/Source/devtools/front_end/data_grid/ViewportDataGrid.js
+++ b/third_party/WebKit/Source/devtools/front_end/data_grid/ViewportDataGrid.js
@@ -315,11 +315,14 @@ DataGrid.ViewportDataGridNode = class extends DataGrid.DataGridNode {
return this._isStriped;
}
- _clearFlatNodes() {
+ /**
+ * @protected
+ */
+ clearFlatNodes() {
this._flatNodes = null;
var parent = /** @type {!DataGrid.ViewportDataGridNode} */ (this.parent);
if (parent)
- parent._clearFlatNodes();
+ parent.clearFlatNodes();
}
/**
@@ -359,7 +362,7 @@ DataGrid.ViewportDataGridNode = class extends DataGrid.DataGridNode {
* @param {number} index
*/
insertChild(child, index) {
- this._clearFlatNodes();
+ this.clearFlatNodes();
if (child.parent === this) {
var currentIndex = this.children.indexOf(child);
if (currentIndex < 0)
@@ -385,7 +388,7 @@ DataGrid.ViewportDataGridNode = class extends DataGrid.DataGridNode {
* @param {!NODE_TYPE} child
*/
removeChild(child) {
- this._clearFlatNodes();
+ this.clearFlatNodes();
if (this.dataGrid)
this.dataGrid.updateSelectionBeforeRemoval(child, false);
if (child.previousSibling)
@@ -407,7 +410,7 @@ DataGrid.ViewportDataGridNode = class extends DataGrid.DataGridNode {
* @override
*/
removeChildren() {
- this._clearFlatNodes();
+ this.clearFlatNodes();
if (this.dataGrid)
this.dataGrid.updateSelectionBeforeRemoval(this, true);
for (var i = 0; i < this.children.length; ++i)
@@ -435,7 +438,7 @@ DataGrid.ViewportDataGridNode = class extends DataGrid.DataGridNode {
collapse() {
if (!this._expanded)
return;
- this._clearFlatNodes();
+ this.clearFlatNodes();
this._expanded = false;
if (this.existingElement())
this.existingElement().classList.remove('expanded');
@@ -448,7 +451,7 @@ DataGrid.ViewportDataGridNode = class extends DataGrid.DataGridNode {
expand() {
if (this._expanded)
return;
- this._clearFlatNodes();
+ this.clearFlatNodes();
super.expand();
this.dataGrid.scheduleUpdateStructure();
}
@@ -502,7 +505,7 @@ DataGrid.ViewportDataGridNode = class extends DataGrid.DataGridNode {
* @param {number} index
*/
recalculateSiblings(index) {
- this._clearFlatNodes();
+ this.clearFlatNodes();
super.recalculateSiblings(index);
}
};
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698