Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Side by Side Diff: chrome/browser/ui/webui/extensions/extension_loader_handler.h

Issue 2648803002: Convert ExtensionLoaderHandler to use the new navigation callbacks. (Closed)
Patch Set: use GetReloadType Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/webui/extensions/extension_loader_handler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_WEBUI_EXTENSIONS_EXTENSION_LOADER_HANDLER_H_ 5 #ifndef CHROME_BROWSER_UI_WEBUI_EXTENSIONS_EXTENSION_LOADER_HANDLER_H_
6 #define CHROME_BROWSER_UI_WEBUI_EXTENSIONS_EXTENSION_LOADER_HANDLER_H_ 6 #define CHROME_BROWSER_UI_WEBUI_EXTENSIONS_EXTENSION_LOADER_HANDLER_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 58
59 // Try to load an unpacked extension from the given |file_path|. 59 // Try to load an unpacked extension from the given |file_path|.
60 void LoadUnpackedExtension(const base::FilePath& file_path); 60 void LoadUnpackedExtension(const base::FilePath& file_path);
61 61
62 // ExtensionErrorReporter::Observer: 62 // ExtensionErrorReporter::Observer:
63 void OnLoadFailure(content::BrowserContext* browser_context, 63 void OnLoadFailure(content::BrowserContext* browser_context,
64 const base::FilePath& file_path, 64 const base::FilePath& file_path,
65 const std::string& error) override; 65 const std::string& error) override;
66 66
67 // content::WebContentsObserver: 67 // content::WebContentsObserver:
68 void DidStartNavigationToPendingEntry( 68 void DidStartNavigation(
69 const GURL& url, 69 content::NavigationHandle* navigation_handle) override;
70 content::ReloadType reload_type) override;
71 70
72 // Add a failure to |failures_|. If it was a manifest error, |manifest| will 71 // Add a failure to |failures_|. If it was a manifest error, |manifest| will
73 // hold the manifest contents, and |line_number| will point to the line at 72 // hold the manifest contents, and |line_number| will point to the line at
74 // which the error was found. 73 // which the error was found.
75 void AddFailure(const base::FilePath& file_path, 74 void AddFailure(const base::FilePath& file_path,
76 const std::string& error, 75 const std::string& error,
77 size_t line_number, 76 size_t line_number,
78 const std::string& manifest); 77 const std::string& manifest);
79 78
80 // Notify the frontend of all failures. 79 // Notify the frontend of all failures.
(...skipping 19 matching lines...) Expand all
100 99
101 // Weak pointer factory for posting background tasks. 100 // Weak pointer factory for posting background tasks.
102 base::WeakPtrFactory<ExtensionLoaderHandler> weak_ptr_factory_; 101 base::WeakPtrFactory<ExtensionLoaderHandler> weak_ptr_factory_;
103 102
104 DISALLOW_COPY_AND_ASSIGN(ExtensionLoaderHandler); 103 DISALLOW_COPY_AND_ASSIGN(ExtensionLoaderHandler);
105 }; 104 };
106 105
107 } // namespace extensions 106 } // namespace extensions
108 107
109 #endif // CHROME_BROWSER_UI_WEBUI_EXTENSIONS_EXTENSION_LOADER_HANDLER_H_ 108 #endif // CHROME_BROWSER_UI_WEBUI_EXTENSIONS_EXTENSION_LOADER_HANDLER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/webui/extensions/extension_loader_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698