Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(913)

Unified Diff: media/capture/video/linux/camera_config_chromeos.cc

Issue 2648743002: Rotate frames according to camera orientation (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/capture/video/linux/camera_config_chromeos.cc
diff --git a/media/capture/video/linux/camera_facing_chromeos.cc b/media/capture/video/linux/camera_config_chromeos.cc
similarity index 79%
rename from media/capture/video/linux/camera_facing_chromeos.cc
rename to media/capture/video/linux/camera_config_chromeos.cc
index ad54ed4185e757836431ca31c057b91fb4c3df1b..192472612669233bf775d06fb4b47f10c154e971 100644
--- a/media/capture/video/linux/camera_facing_chromeos.cc
+++ b/media/capture/video/linux/camera_config_chromeos.cc
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "camera_facing_chromeos.h"
+#include "camera_config_chromeos.h"
#include <base/files/file_util.h>
#include <base/logging.h>
@@ -20,7 +20,7 @@ namespace {
// /etc/camera/camera_characteristics.conf.
enum LensFacing { FRONT = 0, BACK = 1 };
-bool GetCameraId(const base::StringPiece& sub_key, int* camera_id) {
+bool ParseCameraId(const base::StringPiece& sub_key, int* camera_id) {
const base::StringPiece camera_id_prefix = "camera";
if (!sub_key.starts_with(camera_id_prefix))
return false;
@@ -33,29 +33,56 @@ bool GetCameraId(const base::StringPiece& sub_key, int* camera_id) {
static const char kCameraCharacteristicsConfigFile[] =
"/etc/camera/camera_characteristics.conf";
static const char kLensFacing[] = "lens_facing";
+static const char kSensorOrientation[] = "sensor_orientation";
static const char kUsbVidPid[] = "usb_vid_pid";
static const char kUsbPath[] = "usb_path";
+static const int kOrientationDefault = 0;
-CameraFacingChromeOS::CameraFacingChromeOS() {
+CameraConfigChromeOS::CameraConfigChromeOS() {
InitializeDeviceInfo(std::string(kCameraCharacteristicsConfigFile));
}
-CameraFacingChromeOS::CameraFacingChromeOS(
+CameraConfigChromeOS::CameraConfigChromeOS(
const std::string& config_file_path) {
InitializeDeviceInfo(config_file_path);
}
-CameraFacingChromeOS::~CameraFacingChromeOS() {}
+CameraConfigChromeOS::~CameraConfigChromeOS() {}
-VideoFacingMode CameraFacingChromeOS::GetCameraFacing(
+VideoFacingMode CameraConfigChromeOS::GetCameraFacing(
const std::string& device_id,
const std::string& model_id) const {
+ int camera_id = GetCameraId(device_id, model_id);
+ const auto& camera_id_to_facing_const = camera_id_to_facing_;
+ auto camera_id_iter = camera_id_to_facing_const.find(camera_id);
+ if (camera_id_iter == camera_id_to_facing_const.end()) {
+ DLOG(ERROR) << "Can't find lens_facing of camera ID " << camera_id
+ << " in config file";
+ return kLensFacingDefault;
+ }
+ return camera_id_iter->second;
+}
+
+int CameraConfigChromeOS::GetOrientation(const std::string& device_id,
+ const std::string& model_id) const {
+ int camera_id = GetCameraId(device_id, model_id);
+ const auto& camera_id_to_orientation_const = camera_id_to_orientation_;
+ auto camera_id_iter = camera_id_to_orientation_const.find(camera_id);
+ if (camera_id_iter == camera_id_to_orientation_const.end()) {
+ DLOG(ERROR) << "Can't find sensor_orientation of camera ID " << camera_id
+ << " in config file";
+ return kOrientationDefault;
+ }
+ return camera_id_iter->second;
+}
+
+int CameraConfigChromeOS::GetCameraId(const std::string& device_id,
+ const std::string& model_id) const {
std::string usb_id = GetUsbId(device_id);
const auto& usb_id_to_camera_id_const = usb_id_to_camera_id_;
const auto& model_id_to_camera_id_const = model_id_to_camera_id_;
- const auto& camera_id_to_facing_const = camera_id_to_facing_;
auto usb_id_iter = usb_id_to_camera_id_const.find(usb_id);
- int camera_id;
+ int camera_id = 0;
if (usb_id_iter == usb_id_to_camera_id_const.end()) {
// Can't find Usb ID. Fall back to use model_id.
auto model_id_iter = model_id_to_camera_id_const.find(model_id);
@@ -67,17 +94,10 @@ VideoFacingMode CameraFacingChromeOS::GetCameraFacing(
} else {
camera_id = usb_id_iter->second;
}
-
- auto camera_id_iter = camera_id_to_facing_const.find(camera_id);
- if (camera_id_iter == camera_id_to_facing_const.end()) {
- DLOG(ERROR) << "Can't find lens_facing of camera ID " << camera_id
- << " in config file";
- return kLensFacingDefault;
- }
- return camera_id_iter->second;
+ return camera_id;
}
-std::string CameraFacingChromeOS::GetUsbId(const std::string& device_id) const {
+std::string CameraConfigChromeOS::GetUsbId(const std::string& device_id) const {
// |device_id| is of the form "/dev/video2". We want to retrieve "video2"
// into |file_name|.
const std::string device_dir = "/dev/";
@@ -113,7 +133,7 @@ std::string CameraFacingChromeOS::GetUsbId(const std::string& device_id) const {
return usb_id_pieces[0].as_string();
}
-void CameraFacingChromeOS::InitializeDeviceInfo(
+void CameraConfigChromeOS::InitializeDeviceInfo(
const std::string& config_file_path) {
const base::FilePath path(config_file_path);
std::string content;
@@ -147,7 +167,7 @@ void CameraFacingChromeOS::InitializeDeviceInfo(
continue;
}
int camera_id = 0;
- if (!GetCameraId(sub_keys[0], &camera_id)) {
+ if (!ParseCameraId(sub_keys[0], &camera_id)) {
DLOG(ERROR) << "Invalid sub key for camera id: " << sub_keys[0];
continue;
}
@@ -171,6 +191,13 @@ void CameraFacingChromeOS::InitializeDeviceInfo(
DLOG(ERROR) << "Invalid value for lens_facing: " << lens_facing;
continue;
}
+ } else if (sub_keys.size() == 2 && sub_keys[1] == kSensorOrientation) {
+ int orientation = 0;
+ if (!base::StringToInt(value, &orientation)) {
+ DLOG(ERROR) << "Invalid value for sensor_orientation: " << value;
+ continue;
+ }
+ camera_id_to_orientation_[camera_id] = orientation;
} else if (sub_keys.size() == 3 && sub_keys[2] == kUsbVidPid) {
if (value.empty()) {
DLOG(ERROR) << "model_id is empty";

Powered by Google App Engine
This is Rietveld 408576698