Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(785)

Unified Diff: net/http/transport_security_state_unittest.cc

Issue 2648713002: Add response code to the success callback of ReportSender (Closed)
Patch Set: eroman and estark comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/transport_security_state.cc ('k') | net/url_request/report_sender.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/transport_security_state_unittest.cc
diff --git a/net/http/transport_security_state_unittest.cc b/net/http/transport_security_state_unittest.cc
index 88492c7980d28ce4729caf2549da02070c4c0005..efe7f1f29497afb8424031bbef3d7e71221af36b 100644
--- a/net/http/transport_security_state_unittest.cc
+++ b/net/http/transport_security_state_unittest.cc
@@ -32,6 +32,7 @@
#include "net/cert/test_root_certs.h"
#include "net/cert/x509_cert_types.h"
#include "net/cert/x509_certificate.h"
+#include "net/http/http_status_code.h"
#include "net/http/http_util.h"
#include "net/ssl/ssl_info.h"
#include "net/test/cert_test_util.h"
@@ -100,12 +101,12 @@ class MockCertificateReportSender
MockCertificateReportSender() {}
~MockCertificateReportSender() override {}
- void Send(
- const GURL& report_uri,
- base::StringPiece content_type,
- base::StringPiece report,
- const base::Callback<void()>& success_callback,
- const base::Callback<void(const GURL&, int)>& error_callback) override {
+ void Send(const GURL& report_uri,
+ base::StringPiece content_type,
+ base::StringPiece report,
+ const base::Callback<void()>& success_callback,
+ const base::Callback<void(const GURL&, int, int)>& error_callback)
+ override {
latest_report_uri_ = report_uri;
report.CopyToString(&latest_report_);
content_type.CopyToString(&latest_content_type_);
@@ -137,14 +138,14 @@ class MockFailingCertificateReportSender
int net_error() { return net_error_; }
// TransportSecurityState::ReportSenderInterface:
- void Send(
- const GURL& report_uri,
- base::StringPiece content_type,
- base::StringPiece report,
- const base::Callback<void()>& success_callback,
- const base::Callback<void(const GURL&, int)>& error_callback) override {
+ void Send(const GURL& report_uri,
+ base::StringPiece content_type,
+ base::StringPiece report,
+ const base::Callback<void()>& success_callback,
+ const base::Callback<void(const GURL&, int, int)>& error_callback)
+ override {
ASSERT_FALSE(error_callback.is_null());
- error_callback.Run(report_uri, net_error_);
+ error_callback.Run(report_uri, net_error_, 0);
}
private:
« no previous file with comments | « net/http/transport_security_state.cc ('k') | net/url_request/report_sender.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698