Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: components/certificate_reporting/error_reporter.h

Issue 2648713002: Add response code to the success callback of ReportSender (Closed)
Patch Set: eroman and estark comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/certificate_reporting/error_reporter.h
diff --git a/components/certificate_reporting/error_reporter.h b/components/certificate_reporting/error_reporter.h
index a02610862e2e7c1566f07cf0cc33ae1ce54f3587..91afc00f3348b751a4c989093b0d9e5ab696c251 100644
--- a/components/certificate_reporting/error_reporter.h
+++ b/components/certificate_reporting/error_reporter.h
@@ -60,10 +60,18 @@ class ErrorReporter {
// an HTTP endpoint to send encrypted extended reporting reports. On
// unsupported platforms, callers must send extended reporting reports
// over SSL.
+ //
+ //
+ // Calls |success_callback| when the report is successfully sent and the
+ // server returns an HTTP 200 response.
+ // In all other cases, calls |error_callback| with the URL of the upload,
+ // net error and HTTP response code parameters.
virtual void SendExtendedReportingReport(
const std::string& serialized_report,
const base::Callback<void()>& success_callback,
- const base::Callback<void(const GURL&, int)>& error_callback);
+ const base::Callback<void(const GURL&,
+ int /* net_error */,
+ int /* http_response_code */)>& error_callback);
// Used by tests.
static bool DecryptErrorReport(
« no previous file with comments | « chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc ('k') | components/certificate_reporting/error_reporter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698