Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: chrome/browser/ssl/chrome_expect_ct_reporter.cc

Issue 2648713002: Add response code to the success callback of ReportSender (Closed)
Patch Set: eroman and estark comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/chrome_expect_ct_reporter.cc
diff --git a/chrome/browser/ssl/chrome_expect_ct_reporter.cc b/chrome/browser/ssl/chrome_expect_ct_reporter.cc
index 6cfaf54f37842eb5f9e3910919302a486013d01a..e9e883dfebf34d50e2d98106b2280d6cd6561580 100644
--- a/chrome/browser/ssl/chrome_expect_ct_reporter.cc
+++ b/chrome/browser/ssl/chrome_expect_ct_reporter.cc
@@ -106,7 +106,9 @@ void AddValidSCT(const net::SignedCertificateTimestampAndStatus& sct_and_status,
// Records an UMA histogram of the net errors when Expect CT reports
// fail to send.
-void RecordUMAOnFailure(const GURL& report_uri, int net_error) {
+void RecordUMAOnFailure(const GURL& report_uri,
+ int net_error,
+ int http_response_code) {
UMA_HISTOGRAM_SPARSE_SLOWLY("SSL.ExpectCTReportFailure2", -net_error);
}
@@ -176,6 +178,6 @@ void ChromeExpectCTReporter::OnExpectCTFailed(
UMA_HISTOGRAM_BOOLEAN("SSL.ExpectCTReportSendingAttempt", true);
report_sender_->Send(report_uri, "application/json; charset=utf-8",
- serialized_report, base::Closure(),
+ serialized_report, base::Callback<void()>(),
base::Bind(RecordUMAOnFailure));
}
« no previous file with comments | « chrome/browser/safe_browsing/permission_reporter.cc ('k') | chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698