components/certificate_reporting/error_reporter.h - Issue 2648713002: Add response code to the success callback of ReportSender

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/certificate_reporting/error_reporter.h

Issue 2648713002: Add response code to the success callback of ReportSender (Closed)

Patch Set: Move http_response_code to error callback Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/certificate_reporting/error_reporter.h

diff --git a/components/certificate_reporting/error_reporter.h b/components/certificate_reporting/error_reporter.h

index a02610862e2e7c1566f07cf0cc33ae1ce54f3587..85694088f8000e7aed00934e8ae1d8bd8f73f281 100644

--- a/components/certificate_reporting/error_reporter.h

+++ b/components/certificate_reporting/error_reporter.h

@@ -63,7 +63,7 @@ class ErrorReporter {

virtual void SendExtendedReportingReport(

estark 2017/04/27 00:35:57 nit: can you document what the |error_callback| ar

meacer 2017/04/27 00:56:42 Done.

const std::string& serialized_report,

const base::Callback<void()>& success_callback,

- const base::Callback<void(const GURL&, int)>& error_callback);

+ const base::Callback<void(const GURL&, int, int)>& error_callback);

// Used by tests.

static bool DecryptErrorReport(