Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: chrome/browser/safe_browsing/certificate_reporting_service.h

Issue 2648713002: Add response code to the success callback of ReportSender (Closed)
Patch Set: Move http_response_code to error callback Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/certificate_reporting_service.h
diff --git a/chrome/browser/safe_browsing/certificate_reporting_service.h b/chrome/browser/safe_browsing/certificate_reporting_service.h
index 5d02a23218fafbce8bf5e35cdde78208d5de9720..5248a426e15348d49606ccdc06ade6a812c0a665 100644
--- a/chrome/browser/safe_browsing/certificate_reporting_service.h
+++ b/chrome/browser/safe_browsing/certificate_reporting_service.h
@@ -126,7 +126,10 @@ class CertificateReportingService : public KeyedService {
private:
void SendInternal(const Report& report);
- void ErrorCallback(int report_id, const GURL& url, int error);
+ void ErrorCallback(int report_id,
+ const GURL& url,
+ int error,
eroman 2017/04/26 22:52:28 I suggested updating this to "net_error" to make i
meacer 2017/04/27 00:56:41 Done.
+ int http_response_code);
void SuccessCallback(int report_id);
std::unique_ptr<certificate_reporting::ErrorReporter> error_reporter_;

Powered by Google App Engine
This is Rietveld 408576698