net/url_request/report_sender.cc - Issue 2648713002: Add response code to the success callback of ReportSender

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/report_sender.cc

Issue 2648713002: Add response code to the success callback of ReportSender (Closed)

Patch Set: Remove response code from error callback Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/url_request/report_sender.cc

diff --git a/net/url_request/report_sender.cc b/net/url_request/report_sender.cc

index 96263d7f2b4ea4b1f87e98508e4723613cd3b0dc..19c9c964f562c1a6a7a9330e84d499256711c286 100644

--- a/net/url_request/report_sender.cc

+++ b/net/url_request/report_sender.cc

@@ -93,7 +93,7 @@ void ReportSender::OnResponseStarted(URLRequest* request, int net_error) {

if (!callback_info->error_callback().is_null())

callback_info->error_callback().Run(request->url(), net_error);

} else if (!callback_info->success_callback().is_null()) {

- callback_info->success_callback().Run();

+ callback_info->success_callback().Run(request->GetResponseCode());

}

CHECK_GT(inflight_requests_.erase(request), 0u);