Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2362)

Unified Diff: chrome/browser/safe_browsing/certificate_reporting_service.h

Issue 2648713002: Add response code to the success callback of ReportSender (Closed)
Patch Set: Remove response code from error callback Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/certificate_reporting_service.h
diff --git a/chrome/browser/safe_browsing/certificate_reporting_service.h b/chrome/browser/safe_browsing/certificate_reporting_service.h
index 5d02a23218fafbce8bf5e35cdde78208d5de9720..98cbffd3b658bfb75faabc682bee716b14bf87b3 100644
--- a/chrome/browser/safe_browsing/certificate_reporting_service.h
+++ b/chrome/browser/safe_browsing/certificate_reporting_service.h
@@ -127,7 +127,7 @@ class CertificateReportingService : public KeyedService {
private:
void SendInternal(const Report& report);
void ErrorCallback(int report_id, const GURL& url, int error);
- void SuccessCallback(int report_id);
+ void SuccessCallback(int report_id, int response_code);
eroman 2017/04/25 21:02:39 can you document what this means, or give it a mor
meacer 2017/04/26 22:27:06 Renamed to http_response_code and documented the c
std::unique_ptr<certificate_reporting::ErrorReporter> error_reporter_;
std::unique_ptr<BoundedReportList> retry_list_;

Powered by Google App Engine
This is Rietveld 408576698