Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: net/http/transport_security_state_unittest.cc

Issue 2648713002: Add response code to the success callback of ReportSender (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/transport_security_state_unittest.cc
diff --git a/net/http/transport_security_state_unittest.cc b/net/http/transport_security_state_unittest.cc
index 7fb0b491049ba0a661003c451a3f81d6fdf5bad5..dba04481006a0449e6b2c3199e7aae051bbd5ccc 100644
--- a/net/http/transport_security_state_unittest.cc
+++ b/net/http/transport_security_state_unittest.cc
@@ -89,12 +89,12 @@ class MockCertificateReportSender
MockCertificateReportSender() {}
~MockCertificateReportSender() override {}
- void Send(
- const GURL& report_uri,
- base::StringPiece content_type,
- base::StringPiece report,
- const base::Callback<void()>& success_callback,
- const base::Callback<void(const GURL&, int)>& error_callback) override {
+ void Send(const GURL& report_uri,
+ base::StringPiece content_type,
+ base::StringPiece report,
+ const base::Callback<void(int)>& success_callback,
+ const base::Callback<void(const GURL&, int, int)>& error_callback)
+ override {
latest_report_uri_ = report_uri;
report.CopyToString(&latest_report_);
content_type.CopyToString(&latest_content_type_);
@@ -126,14 +126,14 @@ class MockFailingCertificateReportSender
int net_error() { return net_error_; }
// TransportSecurityState::ReportSenderInterface:
- void Send(
- const GURL& report_uri,
- base::StringPiece content_type,
- base::StringPiece report,
- const base::Callback<void()>& success_callback,
- const base::Callback<void(const GURL&, int)>& error_callback) override {
+ void Send(const GURL& report_uri,
+ base::StringPiece content_type,
+ base::StringPiece report,
+ const base::Callback<void(int)>& success_callback,
+ const base::Callback<void(const GURL&, int, int)>& error_callback)
+ override {
ASSERT_FALSE(error_callback.is_null());
- error_callback.Run(report_uri, net_error_);
+ error_callback.Run(report_uri, net_error_, 0);
}
private:

Powered by Google App Engine
This is Rietveld 408576698