Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: components/certificate_reporting/error_reporter_unittest.cc

Issue 2648713002: Add response code to the success callback of ReportSender (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/certificate_reporting/error_reporter_unittest.cc
diff --git a/components/certificate_reporting/error_reporter_unittest.cc b/components/certificate_reporting/error_reporter_unittest.cc
index e124c6e2fe3c90e08a3fc5caddd7830942fa409f..83150068d8b29db5c8db1a6ed05fba3d4f9e5739 100644
--- a/components/certificate_reporting/error_reporter_unittest.cc
+++ b/components/certificate_reporting/error_reporter_unittest.cc
@@ -33,12 +33,15 @@ const char kDummyHttpsReportUri[] = "https://example.test";
const char kDummyReport[] = "a dummy report";
const uint32_t kServerPublicKeyTestVersion = 16;
-void ErrorCallback(bool* called, const GURL& report_uri, int net_error) {
+void ErrorCallback(bool* called,
+ const GURL& report_uri,
+ int net_error,
+ int response_code) {
EXPECT_NE(net::OK, net_error);
*called = true;
}
-void SuccessCallback(bool* called) {
+void SuccessCallback(bool* called, int response_code) {
*called = true;
}
@@ -50,12 +53,12 @@ class MockCertificateReportSender : public net::ReportSender {
: net::ReportSender(nullptr, DO_NOT_SEND_COOKIES) {}
~MockCertificateReportSender() override {}
- void Send(
- const GURL& report_uri,
- base::StringPiece content_type,
- base::StringPiece report,
- const base::Callback<void()>& success_callback,
- const base::Callback<void(const GURL&, int)>& error_callback) override {
+ void Send(const GURL& report_uri,
+ base::StringPiece content_type,
+ base::StringPiece report,
+ const base::Callback<void(int)>& success_callback,
+ const base::Callback<void(const GURL&, int, int)>& error_callback)
+ override {
latest_report_uri_ = report_uri;
report.CopyToString(&latest_report_);
content_type.CopyToString(&latest_content_type_);
@@ -127,7 +130,8 @@ TEST_F(ErrorReporterTest, ExtendedReportingSendReport) {
kServerPublicKeyTestVersion,
base::WrapUnique(mock_report_sender));
https_reporter.SendExtendedReportingReport(
- kDummyReport, base::Closure(), base::Callback<void(const GURL&, int)>());
+ kDummyReport, base::Callback<void(int)>(),
+ base::Callback<void(const GURL&, int, int)>());
EXPECT_EQ(mock_report_sender->latest_report_uri(), https_url);
EXPECT_EQ(mock_report_sender->latest_report(), kDummyReport);
@@ -139,7 +143,8 @@ TEST_F(ErrorReporterTest, ExtendedReportingSendReport) {
kServerPublicKeyTestVersion,
base::WrapUnique(http_mock_report_sender));
http_reporter.SendExtendedReportingReport(
- kDummyReport, base::Closure(), base::Callback<void(const GURL&, int)>());
+ kDummyReport, base::Callback<void(int)>(),
+ base::Callback<void(const GURL&, int, int)>());
EXPECT_EQ(http_mock_report_sender->latest_report_uri(), http_url);
EXPECT_EQ("application/octet-stream",

Powered by Google App Engine
This is Rietveld 408576698