Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4497)

Unified Diff: chrome/browser/safe_browsing/certificate_reporting_service.cc

Issue 2648713002: Add response code to the success callback of ReportSender (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/certificate_reporting_service.cc
diff --git a/chrome/browser/safe_browsing/certificate_reporting_service.cc b/chrome/browser/safe_browsing/certificate_reporting_service.cc
index d0fb362c53701d89d6850c56ae7a62a5e22eff63..46f0c569ae0d8f1cda2dec49014bcc154de9a4c8 100644
--- a/chrome/browser/safe_browsing/certificate_reporting_service.cc
+++ b/chrome/browser/safe_browsing/certificate_reporting_service.cc
@@ -143,7 +143,8 @@ void CertificateReportingService::Reporter::SendInternal(
void CertificateReportingService::Reporter::ErrorCallback(int report_id,
const GURL& url,
- int error) {
+ int error,
+ int response_code) {
DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
RecordUMAOnFailure(error);
Nathan Parker 2017/02/07 01:33:01 How about also logging the response_code to UMA no
if (retries_enabled_) {
@@ -154,7 +155,8 @@ void CertificateReportingService::Reporter::ErrorCallback(int report_id,
CHECK_GT(inflight_reports_.erase(report_id), 0u);
}
-void CertificateReportingService::Reporter::SuccessCallback(int report_id) {
+void CertificateReportingService::Reporter::SuccessCallback(int report_id,
+ int response_code) {
DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
CHECK_GT(inflight_reports_.erase(report_id), 0u);
}

Powered by Google App Engine
This is Rietveld 408576698