Add response code to the success callback of ReportSender

chrome/browser/safe_browsing/notification_image_reporter.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/safe_browsing/notification_image_reporter.h"
 
 #include <cmath>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/feature_list.h"
 #include "base/logging.h"
 #include "base/memory/ptr_util.h"
 #include "base/memory/ref_counted_memory.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/rand_util.h"
 #include "base/threading/sequenced_worker_pool.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/safe_browsing/safe_browsing_service.h"
 #include "components/safe_browsing/csd.pb.h"
 #include "components/safe_browsing_db/database_manager.h"
 #include "components/safe_browsing_db/safe_browsing_prefs.h"
 #include "components/variations/variations_associated_data.h"
 #include "content/public/browser/browser_thread.h"
 #include "net/base/net_errors.h"
+#include "net/http/http_status_code.h"
 #include "net/url_request/report_sender.h"
 #include "skia/ext/image_operations.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "ui/gfx/codec/png_codec.h"
 #include "ui/gfx/geometry/size.h"
 #include "url/gurl.h"
 
 using content::BrowserThread;
 
 namespace safe_browsing {
 
 namespace {
 
 const size_t kMaxReportsPerDay = 5;
 const base::Feature kNotificationImageReporterFeature{
     "NotificationImageReporterFeature", base::FEATURE_ENABLED_BY_DEFAULT};
 const char kReportChance[] = "ReportChance";
 const char kDefaultMimeType[] = "image/png";
 
 // Passed to ReportSender::Send as an ErrorCallback, so must take a GURL, but it
 // is unused.
-void LogReportResult(const GURL& url, int net_error) {
+void LogReportResult(const GURL& url, int net_error, int http_response_code) {
   UMA_HISTOGRAM_SPARSE_SLOWLY("SafeBrowsing.NotificationImageReporter.NetError",
                               net_error);
 }
 
 }  // namespace
 
 const char NotificationImageReporter::kReportingUploadUrl[] =
     "https://safebrowsing.googleusercontent.com/safebrowsing/clientreport/"
     "notification-image";
 
@@ skipping 150 matching lines @@
   report.mutable_image()->mutable_dimensions()->set_height(dimensions.height());
   if (dimensions != original_dimensions) {
     report.mutable_image()->mutable_original_dimensions()->set_width(
         original_dimensions.width());
     report.mutable_image()->mutable_original_dimensions()->set_height(
         original_dimensions.height());
   }
 
   std::string serialized_report;
   report.SerializeToString(&serialized_report);
-  report_sender_->Send(
-      GURL(kReportingUploadUrl), "application/octet-stream", serialized_report,
-      base::Bind(&LogReportResult, GURL(kReportingUploadUrl), net::OK),
-      base::Bind(&LogReportResult));
+  report_sender_->Send(GURL(kReportingUploadUrl), "application/octet-stream",
+                       serialized_report,
+                       base::Bind(&LogReportResult, GURL(kReportingUploadUrl),
+                                  net::OK, net::HTTP_OK),
+                       base::Bind(&LogReportResult));
   // TODO(johnme): Consider logging bandwidth and/or duration to UMA.
 }
 
 }  // namespace safe_browsing