Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Side by Side Diff: chrome/browser/ssl/chrome_expect_ct_reporter.cc

Issue 2648713002: Add response code to the success callback of ReportSender (Closed)
Patch Set: Remove response code from error callback Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ssl/chrome_expect_ct_reporter.h" 5 #include "chrome/browser/ssl/chrome_expect_ct_reporter.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/base64.h" 9 #include "base/base64.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 158 matching lines...) Expand 10 before | Expand all | Expand 10 after
169 169
170 std::string serialized_report; 170 std::string serialized_report;
171 if (!base::JSONWriter::Write(report, &serialized_report)) { 171 if (!base::JSONWriter::Write(report, &serialized_report)) {
172 LOG(ERROR) << "Failed to serialize Expect CT report"; 172 LOG(ERROR) << "Failed to serialize Expect CT report";
173 return; 173 return;
174 } 174 }
175 175
176 UMA_HISTOGRAM_BOOLEAN("SSL.ExpectCTReportSendingAttempt", true); 176 UMA_HISTOGRAM_BOOLEAN("SSL.ExpectCTReportSendingAttempt", true);
177 177
178 report_sender_->Send(report_uri, "application/json; charset=utf-8", 178 report_sender_->Send(report_uri, "application/json; charset=utf-8",
179 serialized_report, base::Closure(), 179 serialized_report, base::Callback<void(int)>(),
180 base::Bind(RecordUMAOnFailure)); 180 base::Bind(RecordUMAOnFailure));
181 } 181 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698