Building the table for speed releasing.

dashboard/dashboard/create_health_report.py

 # Copyright 2017 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Provides the web interface for adding and editing sheriff rotations."""
 
+import logging
 import json
 
 from google.appengine.api import users
 
 from dashboard.common import request_handler
 from dashboard.common import utils
 from dashboard.common import xsrf
 from dashboard.models import table_config
 
 
@@ skipping 34 matching lines @@
     master_bot = self.request.get('tableBots').splitlines()
     tests = self.request.get('tableTests').splitlines()
     table_layout = self.request.get('tableLayout')
     user = users.get_current_user()
     if not name or not master_bot or not tests or not table_layout or not user:
       self.response.out.write(json.dumps({
           'error': 'Please fill out the form entirely.'
           }))
       return
 
-    created_table, msg = table_config.CreateTableConfig(
-        name=name, bots=master_bot, tests=tests, layout=table_layout,
-        username=user.email())
+    try:
+      created_table = table_config.CreateTableConfig(
+          name=name, bots=master_bot, tests=tests, layout=table_layout,
+          username=user.email())
+    except table_config.BadRequestError as error:
+      self.response.out.write(json.dumps({
+          'error': error.message,
+      }))
+      logging.error(error.message)
+      return
+
 
     if created_table:
       self.response.out.write(json.dumps({
           'name': name,
       }))
     else:
       self.response.out.write(json.dumps({
-          'error': msg,
+          'error': 'Could not create table.',

[sullivan, 2017/01/31 16:36:47]

Should probably also log an error here. Imagine that your users are getting this
message. You'll want to check go/chromeperf-logs. But which request had the
problem? Leaving a breadcrumb here can eliminate wasted time digging into the
wrong request.

       }))
 
   def _ValidateToken(self):
     user = users.get_current_user()
     token = str(self.request.get('xsrf_token'))
     if not user or not xsrf._ValidateToken(token, user):
       self.abort(403)