Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2648653005: js_runtime: help type inference of string replace (Closed)

Created:
3 years, 11 months ago by sra1
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

js_runtime: help type inference of string replace BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/8afc57826488033eee0eb323fe8901b56da304a5

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M sdk/lib/_internal/js_runtime/lib/string_helper.dart View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 5 (2 generated)
sra1
Removes ~40 null receiver checks in a large app
3 years, 11 months ago (2017-01-21 02:16:41 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2648653005/diff/1/sdk/lib/_internal/js_runtime/lib/string_helper.dart File sdk/lib/_internal/js_runtime/lib/string_helper.dart (right): https://codereview.chromium.org/2648653005/diff/1/sdk/lib/_internal/js_runtime/lib/string_helper.dart#newcode145 sdk/lib/_internal/js_runtime/lib/string_helper.dart:145: return JS('String', '#', replacement); // help type inference. ...
3 years, 11 months ago (2017-01-23 17:45:04 UTC) #3
sra1
3 years, 11 months ago (2017-01-23 21:39:04 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
8afc57826488033eee0eb323fe8901b56da304a5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698