cros: Support YUYV format for GPU memory buffer video frames

gpu/ipc/common/gpu_memory_buffer_support.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/ipc/common/gpu_memory_buffer_support.h"
 
+#include "base/command_line.h"
 #include "base/logging.h"
 #include "build/build_config.h"
+#include "gpu/ipc/common/gpu_switches.h"
+#include "ui/gl/gl_bindings.h"
+#include "ui/gl/gl_switches.h"
 
 #if defined(USE_OZONE)
 #include "ui/ozone/public/client_native_pixmap_factory.h"
 #endif
 
 namespace gpu {
 
+bool AreNativeGpuMemoryBuffersEnabled() {
+  // Disable native buffers when using Mesa.

[marcheu1, 2017/01/21 00:25:18]

this comment is misleading, this is osmesa not mesa

[dshwang, 2017/01/23 23:13:42]

Thx for noting. Done.
This part is from existing gpu/ipc/host/gpu_memory_buffer_support.cc tho.

+  if (base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
+          switches::kUseGL) == gl::kGLImplementationOSMesaName) {
+    return false;
+  }
+
+#if defined(OS_MACOSX)
+  return !base::CommandLine::ForCurrentProcess()->HasSwitch(
+      switches::kDisableNativeGpuMemoryBuffers);
+#else
+  return base::CommandLine::ForCurrentProcess()->HasSwitch(
+      switches::kEnableNativeGpuMemoryBuffers);
+#endif
+}
+
 gfx::GpuMemoryBufferType GetNativeGpuMemoryBufferType() {
 #if defined(OS_MACOSX)
   return gfx::IO_SURFACE_BUFFER;
 #endif
 #if defined(USE_OZONE)
   return gfx::OZONE_NATIVE_PIXMAP;
 #endif
   return gfx::EMPTY_BUFFER;
 }
 
 bool IsNativeGpuMemoryBufferConfigurationSupported(gfx::BufferFormat format,
                                                    gfx::BufferUsage usage) {
+  bool never_cpu_read =
+      usage == gfx::BufferUsage::SCANOUT || usage == gfx::BufferUsage::GPU_READ;

[marcheu1, 2017/01/21 00:25:18]

what does scanout have to do with cpu read? Don't we have a flag for CPU read?

[dshwang, 2017/01/23 23:13:42]

must use gfx::BufferUsage::GPU_READ_CPU_READ_WRITE or
gfx::BufferUsage::GPU_READ_CPU_READ_WRITE_PERSISTENT
This confusing is from --enable-native-gpu-buffer-memory flags
Even though native GBM is disabled, scanout native GBM is used. e.g.
output_surface, video, webgl.

--enable-native-gpu-buffer-memory may should be changed to
--enable-native-gpu-buffer-memory-"map"

see GetNativeGpuMemoryBufferConfigurations() calling this function, even if
native GBM is disabled.

It needs refactorying. I'll do it in next CL, as this CL is already big.

+  if (!(AreNativeGpuMemoryBuffersEnabled() || never_cpu_read))
+    return false;
+
   DCHECK_NE(gfx::SHARED_MEMORY_BUFFER, GetNativeGpuMemoryBufferType());
   DCHECK_NE(gfx::EMPTY_BUFFER, GetNativeGpuMemoryBufferType());
 #if defined(OS_MACOSX)
   switch (usage) {
     case gfx::BufferUsage::GPU_READ:
     case gfx::BufferUsage::SCANOUT:
       return format == gfx::BufferFormat::BGRA_8888 ||
              format == gfx::BufferFormat::RGBA_8888 ||
              format == gfx::BufferFormat::BGRX_8888;
     case gfx::BufferUsage::GPU_READ_CPU_READ_WRITE:
@@ skipping 13 matching lines @@
     return false;
   }
   return ui::ClientNativePixmapFactory::GetInstance()->IsConfigurationSupported(
       format, usage);
 #endif
 
   NOTREACHED();
   return false;
 }
 
+GpuMemoryBufferConfigurationSet GetNativeGpuMemoryBufferConfigurations() {
+  GpuMemoryBufferConfigurationSet configurations;
+
+#if defined(USE_OZONE) || defined(OS_MACOSX)
+  if (AreNativeGpuMemoryBuffersEnabled()) {
+    const gfx::BufferFormat kNativeFormats[] = {
+        gfx::BufferFormat::R_8,       gfx::BufferFormat::RG_88,
+        gfx::BufferFormat::BGR_565,   gfx::BufferFormat::RGBA_4444,
+        gfx::BufferFormat::RGBA_8888, gfx::BufferFormat::BGRA_8888,
+        gfx::BufferFormat::UYVY_422,  gfx::BufferFormat::YUYV_422,
+        gfx::BufferFormat::YVU_420,   gfx::BufferFormat::YUV_420_BIPLANAR};
+    const gfx::BufferUsage kNativeUsages[] = {
+        gfx::BufferUsage::GPU_READ, gfx::BufferUsage::SCANOUT,
+        gfx::BufferUsage::GPU_READ_CPU_READ_WRITE,
+        gfx::BufferUsage::GPU_READ_CPU_READ_WRITE_PERSISTENT};
+    for (auto format : kNativeFormats) {
+      for (auto usage : kNativeUsages) {
+        if (IsNativeGpuMemoryBufferConfigurationSupported(format, usage))
+          configurations.insert(std::make_pair(format, usage));
+      }
+    }
+  }
+
+  // Disable native buffers only when using Mesa.

[marcheu1, 2017/01/21 00:25:18]

again this is osmesa

[dshwang, 2017/01/23 23:13:42]

Done.

+  bool force_native_gpu_read_write_formats =
+      base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
+          switches::kUseGL) != gl::kGLImplementationOSMesaName;
+  if (force_native_gpu_read_write_formats) {
+    const gfx::BufferFormat kGPUReadWriteFormats[] = {
+        gfx::BufferFormat::BGR_565,   gfx::BufferFormat::RGBA_8888,
+        gfx::BufferFormat::RGBX_8888, gfx::BufferFormat::BGRA_8888,
+        gfx::BufferFormat::BGRX_8888, gfx::BufferFormat::UYVY_422,
+        gfx::BufferFormat::YVU_420,   gfx::BufferFormat::YUV_420_BIPLANAR};

[marcheu1, 2017/01/21 00:25:18]

why are you hardcoding this table here?

[dshwang, 2017/01/23 23:13:42]

I just merge existing gpu/ipc/host/gpu_memory_buffer_support.cc to here. Short
answer is because the functions were seperated in host/ and common/, but now we
can hardcode only one time. I'll refactor this in next CL.

+    const gfx::BufferUsage kGPUReadWriteUsages[] = {gfx::BufferUsage::GPU_READ,
+                                                    gfx::BufferUsage::SCANOUT};
+    for (auto format : kGPUReadWriteFormats) {
+      for (auto usage : kGPUReadWriteUsages) {
+        if (IsNativeGpuMemoryBufferConfigurationSupported(format, usage))
+          configurations.insert(std::make_pair(format, usage));
+      }
+    }
+  }
+#endif  // defined(USE_OZONE) || defined(OS_MACOSX)
+
+  return configurations;
+}
+
+uint32_t GetImageTextureTarget(gfx::BufferFormat format,
+                               gfx::BufferUsage usage) {
+#if defined(USE_OZONE) || defined(OS_MACOSX)
+  GpuMemoryBufferConfigurationSet native_configurations =
+      GetNativeGpuMemoryBufferConfigurations();
+  if (native_configurations.find(std::make_pair(format, usage)) ==
+      native_configurations.end()) {
+    return GL_TEXTURE_2D;
+  }
+
+  switch (GetNativeGpuMemoryBufferType()) {
+    case gfx::OZONE_NATIVE_PIXMAP:
+      // GPU memory buffers that are shared with the GL using EGLImages
+      // require TEXTURE_EXTERNAL_OES.
+      return GL_TEXTURE_EXTERNAL_OES;
+    case gfx::IO_SURFACE_BUFFER:
+      // IOSurface backed images require GL_TEXTURE_RECTANGLE_ARB.
+      return GL_TEXTURE_RECTANGLE_ARB;
+    case gfx::SHARED_MEMORY_BUFFER:
+    case gfx::EMPTY_BUFFER:
+      break;
+  }
+  NOTREACHED();
+  return GL_TEXTURE_2D;
+#else  // defined(USE_OZONE) || defined(OS_MACOSX)
+  return GL_TEXTURE_2D;
+#endif
+}
+
 }  // namespace gpu