cros: Support YUYV format for GPU memory buffer video frames

gpu/command_buffer/service/feature_info.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/feature_info.h"
 
 #include <stddef.h>
 
 #include <set>
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_split.h"
 #include "gpu/command_buffer/service/gpu_switches.h"
 #include "gpu/command_buffer/service/texture_definition.h"
 #include "gpu/config/gpu_switches.h"
 #include "ui/gl/gl_bindings.h"
 #include "ui/gl/gl_fence.h"
 #include "ui/gl/gl_implementation.h"
 #include "ui/gl/gl_switches.h"
 #include "ui/gl/gl_version_info.h"
 
+#if defined(OS_CHROMEOS)
+#include "ui/gl/gl_surface_egl.h"
+#endif
+
 #if !defined(OS_MACOSX)
 #include "ui/gl/gl_fence_egl.h"
 #endif
 
 namespace gpu {
 namespace gles2 {
 
 namespace {
 
 struct FormatInfo {
@@ skipping 979 matching lines @@
 
   if (gl_version_info_->is_es3 ||
       extensions.Contains("GL_OES_standard_derivatives") ||
       gl::HasDesktopGLFeatures()) {
     AddExtensionString("GL_OES_standard_derivatives");
     feature_flags_.oes_standard_derivatives = true;
     validators_.hint_target.AddValue(GL_FRAGMENT_SHADER_DERIVATIVE_HINT_OES);
     validators_.g_l_state.AddValue(GL_FRAGMENT_SHADER_DERIVATIVE_HINT_OES);
   }
 
+  if (extensions.Contains("GL_APPLE_ycbcr_422")) {
+    AddExtensionString("GL_CHROMIUM_ycbcr_422_image");
+    feature_flags_.chromium_image_ycbcr_422 = true;
+  }
+
   if (extensions.Contains("GL_OES_EGL_image_external")) {
     AddExtensionString("GL_OES_EGL_image_external");
     feature_flags_.oes_egl_image_external = true;
+#if defined(OS_CHROMEOS) && defined(ARCH_CPU_X86_FAMILY)
+    // TODO(dshwang): when ARM support YUYV, remove ARCH_CPU_X86_FAMILY check.

[marcheu1, 2017/01/21 00:25:18]

Som ARM platforms already support YUYV, please don't add the X86 check it isn't
needed.

[dshwang, 2017/01/23 23:13:42]

Ok, remove the X86 check. and the code is protected by native GBM flags, so it's
safe to allow ARM anyway.

+    // crbug.com/683347
+    bool has_dma_buf_import =
+        gl::GLSurfaceEGL::HasEGLExtension("EGL_EXT_image_dma_buf_import");

[marcheu1, 2017/01/21 00:25:18]

we might not need to test this, dma_buf_import is a hard requirement for Chrome
OS

[dshwang, 2017/01/23 23:13:42]

In ChromeOS, GLImageOzoneNativePixmap binds YUYV dmabuf to EGLImage using
dma_buf_import extensions. SO chromium_image_ycbcr_422 in ChromeOS needs the
extensions.

+    if (has_dma_buf_import) {
+      AddExtensionString("GL_CHROMIUM_ycbcr_422_image");

[marcheu1, 2017/01/21 00:25:18]

I think it's incorrect to prevent allocation of images based on a GL extension?
gbm already provides the ability to tell if allocation is possible. The ability
to import into GL should be a separate thing.

[dshwang, 2017/01/23 23:13:42]

gbm already provides the ability to tell if allocation is possible, but gbm
doesn't provide the information if the buffer can be bound to EGLImage. There is
not EGL query API for this.
We don't know before actuall glEGLImageTargetTexture2DOES() call, in which
GLImageEGL::BindTexImage(). If it isn't supported, EGL emits egl error.

chromium_image_ycbcr_422 in ChromeOS is EGL Image backed by YUYV dma buf.

+      feature_flags_.chromium_image_ycbcr_422 = true;
+    }
+#endif
   }
   if (extensions.Contains("GL_NV_EGL_stream_consumer_external")) {
     AddExtensionString("GL_NV_EGL_stream_consumer_external");
     feature_flags_.nv_egl_stream_consumer_external = true;
   }
 
   if (feature_flags_.oes_egl_image_external ||
       feature_flags_.nv_egl_stream_consumer_external) {
     validators_.texture_bind_target.AddValue(GL_TEXTURE_EXTERNAL_OES);
     validators_.get_tex_param_target.AddValue(GL_TEXTURE_EXTERNAL_OES);
@@ skipping 76 matching lines @@
 
 #if defined(OS_MACOSX)
   // TODO(dcastagna): Determine ycbcr_420v_image on CrOS at runtime
   // querying minigbm. crbug.com/646148
   if (gl::GetGLImplementation() != gl::kGLImplementationOSMesaGL) {
     AddExtensionString("GL_CHROMIUM_ycbcr_420v_image");
     feature_flags_.chromium_image_ycbcr_420v = true;
   }
 #endif
 
-  if (extensions.Contains("GL_APPLE_ycbcr_422")) {
-    AddExtensionString("GL_CHROMIUM_ycbcr_422_image");
-    feature_flags_.chromium_image_ycbcr_422 = true;
-  }
-
   // TODO(gman): Add support for these extensions.
   //     GL_OES_depth32
 
   if (extensions.Contains("GL_ANGLE_texture_usage")) {
     feature_flags_.angle_texture_usage = true;
     AddExtensionString("GL_ANGLE_texture_usage");
     validators_.texture_parameter.AddValue(GL_TEXTURE_USAGE_ANGLE);
   }
 
   if (enable_texture_storage) {
@@ skipping 450 matching lines @@
   if (pos == std::string::npos) {
     extensions_ += (extensions_.empty() ? "" : " ") + str;
   }
 }
 
 FeatureInfo::~FeatureInfo() {
 }
 
 }  // namespace gles2
 }  // namespace gpu