cros: Support YUYV format for GPU memory buffer video frames

content/renderer/media/renderer_gpu_video_accelerator_factories.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/renderer_gpu_video_accelerator_factories.h"
 
 #include <GLES2/gl2.h>
 #include <GLES2/gl2ext.h>
 
 #include "base/bind.h"
 #include "base/memory/ptr_util.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/unguessable_token.h"
 #include "cc/output/context_provider.h"
 #include "content/child/child_thread_impl.h"
 #include "content/renderer/render_thread_impl.h"
 #include "gpu/command_buffer/client/gles2_interface.h"
 #include "gpu/command_buffer/client/gpu_memory_buffer_manager.h"
 #include "gpu/ipc/client/gpu_channel_host.h"
+#include "gpu/ipc/common/gpu_memory_buffer_support.h"
 #include "media/gpu/gpu_video_accelerator_util.h"
 #include "media/gpu/ipc/client/gpu_video_decode_accelerator_host.h"
 #include "media/gpu/ipc/client/gpu_video_encode_accelerator_host.h"
 #include "media/gpu/ipc/common/media_messages.h"
 #include "media/video/video_decode_accelerator.h"
 #include "media/video/video_encode_accelerator.h"
 #include "services/ui/public/cpp/gpu/context_provider_command_buffer.h"
 
 namespace content {
 
@@ skipping 231 matching lines @@
 
 media::GpuVideoAcceleratorFactories::OutputFormat
 RendererGpuVideoAcceleratorFactories::VideoFrameOutputFormat() {
   DCHECK(task_runner_->BelongsToCurrentThread());
   if (CheckContextLost())
     return media::GpuVideoAcceleratorFactories::OutputFormat::UNDEFINED;
   cc::ContextProvider::ScopedContextLock lock(context_provider_);
   auto capabilities = context_provider_->ContextCapabilities();
   if (capabilities.image_ycbcr_420v)
     return media::GpuVideoAcceleratorFactories::OutputFormat::NV12_SINGLE_GMB;
-  if (capabilities.image_ycbcr_422)
+  if (capabilities.image_ycbcr_422) {
+#if defined(OS_MACOSX)
+    // Mac supports UYVY IOSurface.
     return media::GpuVideoAcceleratorFactories::OutputFormat::UYVY;
+#elif defined(OS_CHROMEOS)
+    // Native GPU memory buffers are required.
+    if (gpu::IsNativeGpuMemoryBufferConfigurationSupported(
+            gfx::BufferFormat::YUYV_422,
+            gfx::BufferUsage::GPU_READ_CPU_READ_WRITE)) {
+      // Mesa EGL supports not UYVY but YUYV image.

[marcheu1, 2017/01/21 00:25:18]

pleaes don't add platform-specific code, even comments like this. If a platform
does or doesn't support a feature, it should be detected at runtime. In this
case it seems you only need to remove that comment.

[dshwang, 2017/01/23 23:13:42]

Done.

+      return media::GpuVideoAcceleratorFactories::OutputFormat::YUYV;
+    }
+#endif
+  }
+
   if (capabilities.texture_rg)
     return media::GpuVideoAcceleratorFactories::OutputFormat::NV12_DUAL_GMB;
   return media::GpuVideoAcceleratorFactories::OutputFormat::UNDEFINED;
 }
 
 namespace {
 class ScopedGLContextLockImpl
     : public media::GpuVideoAcceleratorFactories::ScopedGLContextLock {
  public:
   ScopedGLContextLockImpl(cc::ContextProvider* context_provider)
@@ skipping 47 matching lines @@
   context_provider_refptr_ = nullptr;
 }
 
 scoped_refptr<ui::ContextProviderCommandBuffer>
 RendererGpuVideoAcceleratorFactories::ContextProviderMainThread() {
   DCHECK(main_thread_task_runner_->BelongsToCurrentThread());
   return context_provider_refptr_;
 }
 
 }  // namespace content