Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(836)

Unified Diff: third_party/WebKit/Source/devtools/front_end/protocol/InspectorBackend.js

Issue 2648633002: DevTools: enable backwards-compatibility testing (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/scripts/npm_test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/protocol/InspectorBackend.js
diff --git a/third_party/WebKit/Source/devtools/front_end/protocol/InspectorBackend.js b/third_party/WebKit/Source/devtools/front_end/protocol/InspectorBackend.js
index 3c01fe964b7e0c01ff7d14d5ca99c52d340ad991..5fe804e771ca226361cab58cf9f873a65e756974 100644
--- a/third_party/WebKit/Source/devtools/front_end/protocol/InspectorBackend.js
+++ b/third_party/WebKit/Source/devtools/front_end/protocol/InspectorBackend.js
@@ -634,13 +634,6 @@ Protocol.InspectorBackend._AgentPrototype = class {
* @param {function(*)|function(?Protocol.Error, ?Object)} callback
*/
dispatchResponse(messageObject, methodName, callback) {
- if (messageObject.error && messageObject.error.code !== Protocol.InspectorBackend._ConnectionClosedErrorCode &&
chenwilliam 2017/01/19 23:08:00 I removed this after discussing with @pfeldman bec
dgozman 2017/01/20 17:52:09 Let's land this separately: - I'm worried we will
chenwilliam 2017/01/20 20:19:21 OK, removing from CL. What kind of cleanup on erro
- messageObject.error.code !== Protocol.InspectorBackend.DevToolsStubErrorCode &&
- !Protocol.InspectorBackend.Options.suppressRequestErrors) {
- var id = Protocol.InspectorBackend.Options.dumpInspectorProtocolMessages ? ' with id = ' + messageObject.id : '';
- console.error('Request ' + methodName + id + ' failed. ' + JSON.stringify(messageObject.error));
- }
-
var argumentsArray = [];
argumentsArray[0] = messageObject.error ? messageObject.error.message : null;
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/scripts/npm_test.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698