DevTools: enable backwards-compatibility testing

third_party/WebKit/Source/devtools/front_end/protocol/InspectorBackend.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 616 matching lines @@
   _invoke(method, args, callback) {
     this._target._wrapCallbackAndSendMessageObject(this._domain, method, args, callback);
   }
 
   /**
    * @param {!Object} messageObject
    * @param {string} methodName
    * @param {function(*)|function(?Protocol.Error, ?Object)} callback
    */
   dispatchResponse(messageObject, methodName, callback) {
-    if (messageObject.error && messageObject.error.code !== Protocol.InspectorBackend._ConnectionClosedErrorCode &&

[chenwilliam, 2017/01/19 23:08:00]

I removed this after discussing with @pfeldman because missing protocol methods
are being logged into the test results. Each caller that gracefully handles
missing protocol methods should have a customized log which will be recorded in
the test results.

Example:
error: Request Debugger.getPossibleBreakpoints failed.
{"code":-32601,"message":"'Debugger.getPossibleBreakpoints' wasn't found"}

[dgozman, 2017/01/20 17:52:09]

Let's land this separately:
- I'm worried we will miss some new issues due to no logging;
- removing this allows more cleanup on error codes.

[chenwilliam, 2017/01/20 20:19:21]

OK, removing from CL. What kind of cleanup on error codes do you want? (I can do
it?)

-        messageObject.error.code !== Protocol.InspectorBackend.DevToolsStubErrorCode &&
-        !Protocol.InspectorBackend.Options.suppressRequestErrors) {
-      var id = Protocol.InspectorBackend.Options.dumpInspectorProtocolMessages ? ' with id = ' + messageObject.id : '';
-      console.error('Request ' + methodName + id + ' failed. ' + JSON.stringify(messageObject.error));
-    }
-
     var argumentsArray = [];
     argumentsArray[0] = messageObject.error ? messageObject.error.message : null;
 
     if (this._hasErrorData[methodName])
       argumentsArray[1] = messageObject.error ? messageObject.error.data : null;
 
     if (messageObject.result) {
       var paramNames = this._replyArgs[methodName] || [];
       for (var i = 0; i < paramNames.length; ++i)
         argumentsArray.push(messageObject.result[paramNames[i]]);
@@ skipping 65 matching lines @@
     if (Protocol.InspectorBackend.Options.dumpInspectorTimeStats)
       console.timeEnd(timingLabel);
   }
 };
 
 Protocol.InspectorBackend.Options = {
   dumpInspectorTimeStats: false,
   dumpInspectorProtocolMessages: false,
   suppressRequestErrors: false
 };