Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Issue 26486003: Implement presubmit support for _unittest_win includes, etc. (Closed)

Created:
7 years, 2 months ago by erikwright (departed)
Modified:
7 years, 2 months ago
Reviewers:
Jói
CC:
chromium-reviews, marja
Visibility:
Public.

Description

Implement presubmit support for _unittest_win includes, etc. Without this change, xxx_unittest_win.cc would cause an erroneous presubmit error by including xxx_win.h as its first 'special' include. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227823

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -3 lines) Patch
M PRESUBMIT.py View 3 chunks +13 lines, -3 lines 0 comments Download
M PRESUBMIT_test.py View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
erikwright (departed)
PTAL.
7 years, 2 months ago (2013-10-08 14:27:20 UTC) #1
Jói
LGTM
7 years, 2 months ago (2013-10-09 15:13:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/26486003/1
7 years, 2 months ago (2013-10-09 18:29:54 UTC) #3
commit-bot: I haz the power
7 years, 2 months ago (2013-10-09 22:32:42 UTC) #4
Message was sent while issue was closed.
Change committed as 227823

Powered by Google App Engine
This is Rietveld 408576698