third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp - Issue 2648583004: bluetooth: Stop firing value changed events after gatt disconnects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp

Issue 2648583004: bluetooth: Stop firing value changed events after gatt disconnects (Closed)

Patch Set: Make iframe subscribe to notifications and add comments. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp

diff --git a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp

index 89a1ea228b9310bb9b7cfa6293570c69c9dac058..84b788eb624477537b71c155959ed2a5e14e50b3 100644

--- a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp

+++ b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp

@@ -51,6 +51,8 @@ void BluetoothRemoteGATTCharacteristic::setValue(DOMDataView* domDataView) {

void BluetoothRemoteGATTCharacteristic::dispatchCharacteristicValueChanged(

const Vector<uint8_t>& value) {

+ if (!getGatt()->connected())

+ return;

this->setValue(BluetoothRemoteGATTUtils::ConvertWTFVectorToDataView(value));

dispatchEvent(Event::create(EventTypeNames::characteristicvaluechanged));

}

« no previous file with comments | « third_party/WebKit/LayoutTests/resources/bluetooth/heart-rate-iframe.html ('k') | no next file » | no next file with comments »