third_party/WebKit/LayoutTests/resources/bluetooth/heart-rate-iframe.html - Issue 2648583004: bluetooth: Stop firing value changed events after gatt disconnects

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/resources/bluetooth/heart-rate-iframe.html

Issue 2648583004: bluetooth: Stop firing value changed events after gatt disconnects (Closed)

Patch Set: Make iframe subscribe to notifications and add comments. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script>

	3 let device;

	4 window.onmessage = messageEvent => {

	5 if (messageEvent.data === 'RequestAndConnect') {

	6 navigator.bluetooth.requestDevice({

	7 filters: [{services: ['heart_rate']}]

	8 })

	9 .then(device => device.gatt.connect())

	10 .then(gattServer => {

	11 device = gattServer.device;

	12 parent.postMessage('Connected', '*');

	13 }).catch(err => {

	14 console.error(err);

	15 parent.postMessage('FAIL: ' + err, '*');

	16 });

	17 } else if (messageEvent.data === 'StartNotifications') {

	18 device.gatt.getPrimaryService('heart_rate')

	19 .then(service => service.getCharacteristic('heart_rate_measurement'))

	20 .then(char => char.startNotifications())

	21 .then(char => {

	22 char.addEventListener('characteristicvaluechanged', function() {});

	23 parent.postMessage('NotificationsStarted', '*');

	24 });

	25 }

	26 };

	27 parent.postMessage("Ready", "*");

	28 </script>

OLD	NEW