Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(18)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: third_party/WebKit/LayoutTests/resources/bluetooth/connect-iframe.html
Issue
2648583004
:
bluetooth: Stop firing value changed events after gatt disconnects (Closed)
Patch Set: Make iframe subscribe to notifications and add comments.
Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/notification-after-disconnection.html
third_party/WebKit/LayoutTests/bluetooth/server/disconnect/detach-gc.html
third_party/WebKit/LayoutTests/bluetooth/server/disconnect/gc-detach.html
third_party/WebKit/LayoutTests/resources/bluetooth/connect-iframe.html
third_party/WebKit/LayoutTests/resources/bluetooth/heart-rate-iframe.html
third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp
View unified diff
|
Download patch
« no previous file with comments
|
« third_party/WebKit/LayoutTests/bluetooth/server/disconnect/gc-detach.html
('k') |
third_party/WebKit/LayoutTests/resources/bluetooth/heart-rate-iframe.html »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
<!DOCTYPE html>
2
<script>
3
window.onmessage = messageEvent => {
4
if (messageEvent.data === 'Go') {
5
navigator.bluetooth.requestDevice({
6
filters: [{services: ['heart_rate']}]
7
})
8
.then(device => device.gatt.connect())
9
.then(gattServer => {
10
parent.postMessage('Connected', '*');
11
}).catch(err => {
12
console.error(err);
13
parent.postMessage('FAIL: ' + err, '*');
14
});
15
}
16
};
17
parent.postMessage("Ready", "*");
18
</script>
OLD
NEW
« no previous file with comments
|
« third_party/WebKit/LayoutTests/bluetooth/server/disconnect/gc-detach.html
('k') |
third_party/WebKit/LayoutTests/resources/bluetooth/heart-rate-iframe.html »
('j') |
no next file with comments »
Issue 2648583004: bluetooth: Stop firing value changed events after gatt disconnects (Closed)
Created 3 years, 11 months ago by ortuno
Modified 3 years, 10 months ago
Reviewers: Jeffrey Yasskin
Base URL:
Comments: 6
This is Rietveld
408576698