third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp - Issue 2648583004: bluetooth: Stop firing value changed events after gatt disconnects

Side by Side Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp

Issue 2648583004: bluetooth: Stop firing value changed events after gatt disconnects (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/notification-after-disconnection.html ('K') | « third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/notification-after-disconnection.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "modules/bluetooth/BluetoothRemoteGATTCharacteristic.h"	5 #include "modules/bluetooth/BluetoothRemoteGATTCharacteristic.h"

6	6

7 #include "bindings/core/v8/ScriptPromise.h"	7 #include "bindings/core/v8/ScriptPromise.h"

8 #include "bindings/core/v8/ScriptPromiseResolver.h"	8 #include "bindings/core/v8/ScriptPromiseResolver.h"

9 #include "core/events/Event.h"	9 #include "core/events/Event.h"

10 #include "core/inspector/ConsoleMessage.h"	10 #include "core/inspector/ConsoleMessage.h"

(...skipping 33 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
44 return new BluetoothRemoteGATTCharacteristic(	44 return new BluetoothRemoteGATTCharacteristic(

45 context, std::move(characteristic), service, device);	45 context, std::move(characteristic), service, device);

46 }	46 }

47	47

48 void BluetoothRemoteGATTCharacteristic::setValue(DOMDataView* domDataView) {	48 void BluetoothRemoteGATTCharacteristic::setValue(DOMDataView* domDataView) {

49 m_value = domDataView;	49 m_value = domDataView;

50 }	50 }

51	51

52 void BluetoothRemoteGATTCharacteristic::dispatchCharacteristicValueChanged(	52 void BluetoothRemoteGATTCharacteristic::dispatchCharacteristicValueChanged(

53 const Vector<uint8_t>& value) {	53 const Vector<uint8_t>& value) {

	54 if (!getGatt()->connected())
	Jeffrey Yasskin 2017/01/20 21:29:41 Did/could you double-check that we don't have any Did/could you double-check that we don't have any other cases where we should be checking for disconnection? ortuno 2017/01/24 02:38:25 So there are 7 instances of checking for connected Show quoted text On 2017/01/20 at 21:29:41, Jeffrey Yasskin wrote: > Did/could you double-check that we don't have any other cases where we should be checking for disconnection? So there are 7 instances of checking for connected in the spec: 1. GetGATTChildren [1] which is done in [2][3][4] 2. disconnect [5] which is done in [6] 3. Garbage Collect connection [7] is implemented on the browser side by the device/ layer. 4. characteristic.readValue/writeValue/startNotifications [8][9]10] are done in [11][12][13][14]. I'm surprised we don't check stopNotifications in the spec but we do in chrome. Not sure if spec bug or chrome bug. 5. descriptor.readValue/writeValue [15][16]. readValue is being done in [17] 6. Responding to disconnection [18] is done in [19] 7. Responding to notifications and indications is being done in this patch. [1] https://webbluetoothcg.github.io/web-bluetooth/#ref-for-dom-bluetoothremotega... [2] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/blueto... [3] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/blueto... [4] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/blueto... [5] https://webbluetoothcg.github.io/web-bluetooth/#ref-for-dom-bluetoothremotega... [6] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/blueto... [7] https://webbluetoothcg.github.io/web-bluetooth/#ref-for-dom-bluetoothremotega... [8] https://webbluetoothcg.github.io/web-bluetooth/#ref-for-dom-bluetoothremotega... [9] https://webbluetoothcg.github.io/web-bluetooth/#ref-for-dom-bluetoothremotega... [10] https://webbluetoothcg.github.io/web-bluetooth/#ref-for-dom-bluetoothremotega... [11] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/blueto... [12] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/blueto... [13] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/blueto... [14] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/blueto... [15] https://webbluetoothcg.github.io/web-bluetooth/#ref-for-dom-bluetoothremotega... [16] https://webbluetoothcg.github.io/web-bluetooth/#ref-for-dom-bluetoothremotega... [17] https://codereview.chromium.org/2637343002/diff/60001/third_party/WebKit/Sour... [18] https://webbluetoothcg.github.io/web-bluetooth/#ref-for-dom-bluetoothremotega... [19] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/blueto...
	55 return;

54 this->setValue(BluetoothRemoteGATTUtils::ConvertWTFVectorToDataView(value));	56 this->setValue(BluetoothRemoteGATTUtils::ConvertWTFVectorToDataView(value));

55 dispatchEvent(Event::create(EventTypeNames::characteristicvaluechanged));	57 dispatchEvent(Event::create(EventTypeNames::characteristicvaluechanged));

56 }	58 }

57	59

58 void BluetoothRemoteGATTCharacteristic::contextDestroyed(ExecutionContext*) {	60 void BluetoothRemoteGATTCharacteristic::contextDestroyed(ExecutionContext*) {

59 notifyCharacteristicObjectRemoved();	61 notifyCharacteristicObjectRemoved();

60 }	62 }

61	63

62 void BluetoothRemoteGATTCharacteristic::dispose() {	64 void BluetoothRemoteGATTCharacteristic::dispose() {

63 notifyCharacteristicObjectRemoved();	65 notifyCharacteristicObjectRemoved();

(...skipping 366 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
430 DEFINE_TRACE(BluetoothRemoteGATTCharacteristic) {	432 DEFINE_TRACE(BluetoothRemoteGATTCharacteristic) {

431 visitor->trace(m_service);	433 visitor->trace(m_service);

432 visitor->trace(m_properties);	434 visitor->trace(m_properties);

433 visitor->trace(m_value);	435 visitor->trace(m_value);

434 visitor->trace(m_device);	436 visitor->trace(m_device);

435 EventTargetWithInlineData::trace(visitor);	437 EventTargetWithInlineData::trace(visitor);

436 ContextLifecycleObserver::trace(visitor);	438 ContextLifecycleObserver::trace(visitor);

437 }	439 }

438	440

439 } // namespace blink	441 } // namespace blink

OLD	NEW