Issue 2648583002: Fix front_end's file_repository_test on jsshell.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2648583002: Fix front_end's file_repository_test on jsshell. (Closed)

Created:
3 years, 11 months ago by Paul Berry

Modified:
3 years, 11 months ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Fix front_end's file_repository_test on jsshell. All front_end tests are marked as "RuntimeError, OK" in the status file. Counterintuitively, a test which passes does not seem to be considered "ok". Changing this to "RuntimeError, OK, Pass" solves the problem. TBR=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/129fffb83812978a3eddfb1ce655597715d4b68a

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	pkg/pkg.status	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (1 generated)

Paul Berry

3 years, 11 months ago (2017-01-19 21:21:46 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
129fffb83812978a3eddfb1ce655597715d4b68a (presubmit successful).