Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
3 years, 11 months ago by fbarchard1 Modified:
3 years, 10 months ago Reviewers:
kjellander_chromium Target Ref:
refs/heads/master Project:
libyuv Visibility:
Public. |
DescriptionRoll chromium_revision 941118827f..316b880c55
Change log: https://chromium.googlesource.com/chromium/src/+log/941118827f..316b880c55
Full diff: https://chromium.googlesource.com/chromium/src/+/941118827f..316b880c55
Changed dependencies:
* src/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/03fbd54d8f..f332dd6d
DEPS diff: https://chromium.googlesource.com/chromium/src/+/941118827f..316b880c55/DEPS
Clang version changed 282097:282487
Details: https://chromium.googlesource.com/chromium/src/+/941118827f..316b880c55/tools/clang/scripts/update.py
BUG=None
TEST=None
R=kjellander@chromium.org
Committed: https://chromium.googlesource.com/libyuv/libyuv/+/03510421970e0029bf744feac5c128c2ee22c90c
Patch Set 1 #Patch Set 2 : update version to 941118827f..316b880c55 #Messages
Total messages: 13 (7 generated)
Description was changed from ========== Roll chromium_revision ..316b880c55 Change log: https://chromium.googlesource.com/chromium/src/+log/..316b880c55 Full diff: https://chromium.googlesource.com/chromium/src/+/..316b880c55 Changed dependencies: * src/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... DEPS diff: https://chromium.googlesource.com/chromium/src/+/..316b880c55/DEPS Clang version changed 282097:282487 Details: https://chromium.googlesource.com/chromium/src/+/bdaa23ddfe..316b880c55/tools... BUG=None TEST=None ========== to ========== Roll chromium_revision 941118827f..316b880c55 Change log: https://chromium.googlesource.com/chromium/src/+log/941118827f..316b880c55 Full diff: https://chromium.googlesource.com/chromium/src/+/941118827f..316b880c55 Changed dependencies: * src/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... DEPS diff: https://chromium.googlesource.com/chromium/src/+/941118827f..316b880c55/DEPS Clang version changed 282097:282487 Details: https://chromium.googlesource.com/chromium/src/+/941118827f..316b880c55/tools... BUG=None TEST=None ==========
On 2017/01/19 19:53:36, fbarchard1 wrote: > Description was changed from > > ========== > Roll chromium_revision ..316b880c55 > > Change log: https://chromium.googlesource.com/chromium/src/+log/..316b880c55 > Full diff: https://chromium.googlesource.com/chromium/src/+/..316b880c55 > > Changed dependencies: > * src/third_party/catapult: > https://chromium.googlesource.com/external/github.com/catapult-project/catapu... > > DEPS diff: https://chromium.googlesource.com/chromium/src/+/..316b880c55/DEPS > > Clang version changed 282097:282487 > Details: > https://chromium.googlesource.com/chromium/src/+/bdaa23ddfe..316b880c55/tools... > > BUG=None > TEST=None > ========== > > to > > ========== > Roll chromium_revision 941118827f..316b880c55 > > Change log: > https://chromium.googlesource.com/chromium/src/+log/941118827f..316b880c55 > Full diff: > https://chromium.googlesource.com/chromium/src/+/941118827f..316b880c55 > > Changed dependencies: > * src/third_party/catapult: > https://chromium.googlesource.com/external/github.com/catapult-project/catapu... > > DEPS diff: > https://chromium.googlesource.com/chromium/src/+/941118827f..316b880c55/DEPS > > Clang version changed 282097:282487 > Details: > https://chromium.googlesource.com/chromium/src/+/941118827f..316b880c55/tools... > > BUG=None > TEST=None > ========== That Windows error is still hitting us. A google search seems to indicate it has something to do with parallel builds (which we've been using for a long time): https://issues.jenkins-ci.org/browse/JENKINS-9104 I wonder why it's only hitting libyuv.
The CQ bit was checked by fbarchard@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-libyuv-committers". Note that this has nothing to do with OWNERS files.
On 2017/01/20 06:57:00, kjellander_chromium wrote: > On 2017/01/19 19:53:36, fbarchard1 wrote: > > Description was changed from > > > > ========== > > Roll chromium_revision ..316b880c55 > > > > Change log: https://chromium.googlesource.com/chromium/src/+log/..316b880c55 > > Full diff: https://chromium.googlesource.com/chromium/src/+/..316b880c55 > > > > Changed dependencies: > > * src/third_party/catapult: > > > https://chromium.googlesource.com/external/github.com/catapult-project/catapu... > > > > DEPS diff: https://chromium.googlesource.com/chromium/src/+/..316b880c55/DEPS > > > > Clang version changed 282097:282487 > > Details: > > > https://chromium.googlesource.com/chromium/src/+/bdaa23ddfe..316b880c55/tools... > > > > BUG=None > > TEST=None > > ========== > > > > to > > > > ========== > > Roll chromium_revision 941118827f..316b880c55 > > > > Change log: > > https://chromium.googlesource.com/chromium/src/+log/941118827f..316b880c55 > > Full diff: > > https://chromium.googlesource.com/chromium/src/+/941118827f..316b880c55 > > > > Changed dependencies: > > * src/third_party/catapult: > > > https://chromium.googlesource.com/external/github.com/catapult-project/catapu... > > > > DEPS diff: > > https://chromium.googlesource.com/chromium/src/+/941118827f..316b880c55/DEPS > > > > Clang version changed 282097:282487 > > Details: > > > https://chromium.googlesource.com/chromium/src/+/941118827f..316b880c55/tools... > > > > BUG=None > > TEST=None > > ========== > > That Windows error is still hitting us. A google search seems to indicate it has > something to do with parallel builds (which we've been using for a long time): > https://issues.jenkins-ci.org/browse/JENKINS-9104 > I wonder why it's only hitting libyuv. My local windows build works d:\src\build\libyuv\libyuv>call gn gen out\Release "--args=is_debug=false is_official_build=false target_cpu=\"x86\"" Done. Made 42 targets from 41 files in 1268ms Done. Made 42 targets from 41 files in 1311ms ninja: Entering directory `out\Release' [320/320] STAMP obj/default.stamp ninja: Entering directory `out\Debug' [320/320] STAMP obj/default.stamp
kjellander@chromium.org changed reviewers: + kjellander@chromium.org
lgtm, let's give it a try and see if we can figure out what's causing the Windows breakage.
lgtm, let's give it a try and see if we can figure out what's causing the Windows breakage.
Description was changed from ========== Roll chromium_revision 941118827f..316b880c55 Change log: https://chromium.googlesource.com/chromium/src/+log/941118827f..316b880c55 Full diff: https://chromium.googlesource.com/chromium/src/+/941118827f..316b880c55 Changed dependencies: * src/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... DEPS diff: https://chromium.googlesource.com/chromium/src/+/941118827f..316b880c55/DEPS Clang version changed 282097:282487 Details: https://chromium.googlesource.com/chromium/src/+/941118827f..316b880c55/tools... BUG=None TEST=None ========== to ========== Roll chromium_revision 941118827f..316b880c55 Change log: https://chromium.googlesource.com/chromium/src/+log/941118827f..316b880c55 Full diff: https://chromium.googlesource.com/chromium/src/+/941118827f..316b880c55 Changed dependencies: * src/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... DEPS diff: https://chromium.googlesource.com/chromium/src/+/941118827f..316b880c55/DEPS Clang version changed 282097:282487 Details: https://chromium.googlesource.com/chromium/src/+/941118827f..316b880c55/tools... BUG=None TEST=None R=kjellander@chromium.org Committed: https://chromium.googlesource.com/libyuv/libyuv/+/03510421970e0029bf744feac5c... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 03510421970e0029bf744feac5c128c2ee22c90c (presubmit successful).
Message was sent while issue was closed.
On 2017/01/31 22:46:19, fbarchard1 wrote: > Committed patchset #2 (id:20001) manually as > 03510421970e0029bf744feac5c128c2ee22c90c (presubmit successful). So it fails on the commit bots as well. I reverted this in https://chromium-review.googlesource.com/c/435261/ since we need to resolve this before rolling forward. |
