HttpServer::ParseHeaders: don't DCHECK on bogus headers termination

net/server/http_server.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/server/http_server.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/compiler_specific.h"
@@ skipping 431 matching lines @@
       // Do any actions based on current state
       switch (state) {
         case ST_METHOD:
         case ST_URL:
         case ST_PROTO:
         case ST_VALUE:
         case ST_NAME:
           buffer.append(&ch, 1);
           break;
         case ST_DONE:
-          DCHECK(input == INPUT_LF);
-          return true;
+          // We got CR to get this far, also need the LF
+          return (input == INPUT_LF);
         case ST_ERR:
           return false;
       }
     }
   }
   // No more characters, but we haven't finished parsing yet. Signal this to
   // the caller by setting |pos| to zero.
   pos = 0;
   return true;
 }
 
 HttpConnection* HttpServer::FindConnection(int connection_id) {
   auto it = id_to_connection_.find(connection_id);
   if (it == id_to_connection_.end())
     return nullptr;
   return it->second.get();
 }
 
 // This is called after any delegate callbacks are called to check if Close()
 // has been called during callback processing. Using the pointer of connection,
 // |connection| is safe here because Close() deletes the connection in next run
 // loop.
 bool HttpServer::HasClosedConnection(HttpConnection* connection) {
   return FindConnection(connection->id()) != connection;
 }
 
 }  // namespace net