Implement complex switch statement (switch with continue).

Implement complex switch statement (switch with continue).

BUG=https://github.com/dart-lang/sdk/issues/27394
R=sra@google.com

Committed: https://github.com/dart-lang/sdk/commit/d1027b2605c4bb08943a3024fa9a276f53467b70

[Emily Fortuna, 2017-01-19 01:16:06]

Patchset #1 (id:1) has been deleted

[Emily Fortuna, 2017-01-19 01:16:17]

efortuna@google.com changed reviewers:
+ sra@google.com

[Emily Fortuna, 2017-01-19 01:56:00]

Patchset #1 (id:20001) has been deleted

[Emily Fortuna, 2017-01-19 01:57:13]

This brings us up to 83.1%!

[sra1, 2017-01-19 23:03:48]

LGTM with Ssa - > Ast rename

https://codereview.chromium.org/2648443004/diff/60001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/builder_kernel.dart (right):

https://codereview.chromium.org/2648443004/diff/60001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:1277: /// Shared helper method for
creating the list of constants that make up the
We could drop 'Shared'

https://codereview.chromium.org/2648443004/diff/60001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:1423: nativeBehavior:
native.NativeBehavior.PURE));
So are we using a HForeignCode to pretend the `int` value is a bool so we can
use it directly in `if (target)` ?

Perhaps say we generate  `if (target) while (true) ...`

https://codereview.chromium.org/2648443004/diff/60001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/jump_handler.dart (right):

https://codereview.chromium.org/2648443004/diff/60001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/jump_handler.dart:215: class SsaSwitchCaseJumpHandler
extends SwitchCaseJumpHandler {
Ssa -> Ast
They are both SSA, one from Ast, one from Kernel

[Emily Fortuna, 2017-01-19 23:19:01]

https://codereview.chromium.org/2648443004/diff/60001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/builder_kernel.dart (right):

https://codereview.chromium.org/2648443004/diff/60001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:1277: /// Shared helper method for
creating the list of constants that make up the
On 2017/01/19 23:03:47, sra1 wrote:
> We could drop 'Shared'

Done.

https://codereview.chromium.org/2648443004/diff/60001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:1423: nativeBehavior:
native.NativeBehavior.PURE));
On 2017/01/19 23:03:47, sra1 wrote:
> So are we using a HForeignCode to pretend the `int` value is a bool so we can
> use it directly in `if (target)` ?
> 
> Perhaps say we generate  `if (target) while (true) ...`

yup. that's what's happening. it's rather gross. added a comment.

https://codereview.chromium.org/2648443004/diff/60001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/jump_handler.dart (right):

https://codereview.chromium.org/2648443004/diff/60001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/jump_handler.dart:215: class SsaSwitchCaseJumpHandler
extends SwitchCaseJumpHandler {
On 2017/01/19 23:03:47, sra1 wrote:
> Ssa -> Ast
> They are both SSA, one from Ast, one from Kernel

Done.

[Emily Fortuna, 2017-01-19 23:20:16]

Description was changed from

==========
Implement complex switch statement (switch with continue).

BUG=https://github.com/dart-lang/sdk/issues/27394
==========

to

==========
Implement complex switch statement (switch with continue).

BUG=https://github.com/dart-lang/sdk/issues/27394
R=sra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/d1027b2605c4bb08943a3024fa9a276f53467b70
==========

[Emily Fortuna, 2017-01-19 23:20:17]

Committed patchset #4 (id:100001) manually as
d1027b2605c4bb08943a3024fa9a276f53467b70 (presubmit successful).