Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Issue 26484005: [Android] Remove --keep_test_server_ports as a mandorty option. (Closed)

Created:
7 years, 2 months ago by frankf
Modified:
7 years, 2 months ago
Reviewers:
bulach, Philippe
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

[Android] Remove --keep_test_server_ports as a mandorty option. Perf tests currently expect all perf scripts to support this option. BUG=285470 NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229289

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M build/android/pylib/perf/test_runner.py View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
frankf
7 years, 2 months ago (2013-10-17 01:41:17 UTC) #1
bulach
I think this is still in use? otherwise individual shards will eventually call into ports.py/ResetTestServerPortAllocation() ...
7 years, 2 months ago (2013-10-17 11:07:09 UTC) #2
bulach
actually, sorry, just saw the other side of the patch. :) lgtm!
7 years, 2 months ago (2013-10-17 11:07:57 UTC) #3
Philippe
On 2013/10/17 11:07:57, bulach wrote: > actually, sorry, just saw the other side of the ...
7 years, 2 months ago (2013-10-17 11:18:08 UTC) #4
Philippe
Thanks Frank! LGTM.
7 years, 2 months ago (2013-10-17 11:31:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/frankf@chromium.org/26484005/1
7 years, 2 months ago (2013-10-18 00:47:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/frankf@chromium.org/26484005/1
7 years, 2 months ago (2013-10-18 01:24:29 UTC) #7
commit-bot: I haz the power
7 years, 2 months ago (2013-10-18 03:03:35 UTC) #8
Message was sent while issue was closed.
Change committed as 229289

Powered by Google App Engine
This is Rietveld 408576698