Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 2648383006: Make the VM resilient to a confusion between a NULL instructions snapshot and instructions snapshot… (Closed)

Created:
3 years, 11 months ago by rmacnak
Modified:
3 years, 10 months ago
Reviewers:
Florian Schneider, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make the VM resilient to a confusion between a NULL instructions snapshot and instructions snapshot that is an empty array in the Flutter embedder. Related to issue #28504 R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/ed00447138f95ea4ba612509a244ca8205735372

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M runtime/vm/clustered_snapshot.cc View 1 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
rmacnak
3 years, 11 months ago (2017-01-25 01:39:23 UTC) #2
Florian Schneider
lgtm
3 years, 11 months ago (2017-01-25 02:18:05 UTC) #3
rmacnak
3 years, 10 months ago (2017-01-25 17:58:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ed00447138f95ea4ba612509a244ca8205735372 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698