Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Side by Side Diff: src/crankshaft/hydrogen.cc

Issue 2648383005: Revert "[Parse] ParseInfo owns the parsing Zone." (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/hydrogen.h ('k') | src/debug/debug-scopes.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/crankshaft/hydrogen.h" 5 #include "src/crankshaft/hydrogen.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <sstream> 8 #include <sstream>
9 9
10 #include "src/allocation-site-scopes.h" 10 #include "src/allocation-site-scopes.h"
(...skipping 8017 matching lines...) Expand 10 before | Expand all | Expand 10 after
8028 if (inlined_count_ > Min(FLAG_max_inlined_nodes_cumulative, 8028 if (inlined_count_ > Min(FLAG_max_inlined_nodes_cumulative,
8029 kUnlimitedMaxInlinedNodesCumulative)) { 8029 kUnlimitedMaxInlinedNodesCumulative)) {
8030 TraceInline(target, caller, "cumulative AST node limit reached"); 8030 TraceInline(target, caller, "cumulative AST node limit reached");
8031 return false; 8031 return false;
8032 } 8032 }
8033 8033
8034 // Parse and allocate variables. 8034 // Parse and allocate variables.
8035 // Use the same AstValueFactory for creating strings in the sub-compilation 8035 // Use the same AstValueFactory for creating strings in the sub-compilation
8036 // step, but don't transfer ownership to target_info. 8036 // step, but don't transfer ownership to target_info.
8037 Handle<SharedFunctionInfo> target_shared(target->shared()); 8037 Handle<SharedFunctionInfo> target_shared(target->shared());
8038 ParseInfo parse_info(target_shared, top_info()->parse_info()->zone_shared()); 8038 ParseInfo parse_info(zone(), target_shared);
8039 parse_info.set_ast_value_factory( 8039 parse_info.set_ast_value_factory(
8040 top_info()->parse_info()->ast_value_factory()); 8040 top_info()->parse_info()->ast_value_factory());
8041 parse_info.set_ast_value_factory_owned(false); 8041 parse_info.set_ast_value_factory_owned(false);
8042 8042
8043 CompilationInfo target_info(&parse_info, target); 8043 CompilationInfo target_info(&parse_info, target);
8044 8044
8045 if (inlining_kind != CONSTRUCT_CALL_RETURN && 8045 if (inlining_kind != CONSTRUCT_CALL_RETURN &&
8046 IsClassConstructor(target_shared->kind())) { 8046 IsClassConstructor(target_shared->kind())) {
8047 TraceInline(target, caller, "target is classConstructor"); 8047 TraceInline(target, caller, "target is classConstructor");
8048 return false; 8048 return false;
(...skipping 4973 matching lines...) Expand 10 before | Expand all | Expand 10 after
13022 isolate()->GetHTracer()->TraceHydrogen(name(), graph_); 13022 isolate()->GetHTracer()->TraceHydrogen(name(), graph_);
13023 } 13023 }
13024 13024
13025 #ifdef DEBUG 13025 #ifdef DEBUG
13026 graph_->Verify(false); // No full verify. 13026 graph_->Verify(false); // No full verify.
13027 #endif 13027 #endif
13028 } 13028 }
13029 13029
13030 } // namespace internal 13030 } // namespace internal
13031 } // namespace v8 13031 } // namespace v8
OLDNEW
« no previous file with comments | « src/crankshaft/hydrogen.h ('k') | src/debug/debug-scopes.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698