Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Unified Diff: components/security_state/core/security_state.cc

Issue 2648353005: Display "Not secure" verbose state for data: URLs (Closed)
Patch Set: Fix SSLUI test Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/security_state/core/security_state.cc
diff --git a/components/security_state/core/security_state.cc b/components/security_state/core/security_state.cc
index e1f706562df7e9cd8eb21455e873d78fcee7a0fc..73ce05c13142014c34d9f835461ec58525684de0 100644
--- a/components/security_state/core/security_state.cc
+++ b/components/security_state/core/security_state.cc
@@ -132,6 +132,9 @@ SecurityLevel GetSecurityLevelForRequest(
return DANGEROUS;
}
+ if (url.SchemeIs(url::kDataScheme))
estark 2017/01/26 22:46:28 Could you please add a comment here explaining why
meacer 2017/01/26 23:49:24 Done.
+ return SecurityLevel::HTTP_SHOW_WARNING;
+
// Choose the appropriate security level for HTTP requests.
if (!is_cryptographic_with_certificate) {
if (!is_origin_secure_callback.Run(url) && url.IsStandard()) {

Powered by Google App Engine
This is Rietveld 408576698