Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1972)

Unified Diff: net/nqe/network_quality_estimator.cc

Issue 2648353003: Add effective connection type to throughput mapping (Closed)
Patch Set: ryansturm comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/nqe/network_quality_estimator_params.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/nqe/network_quality_estimator.cc
diff --git a/net/nqe/network_quality_estimator.cc b/net/nqe/network_quality_estimator.cc
index efc3ea9776448845432657a340d73d705be840b1..f2cef5964ac55ac89c0b70c1df490805c7902f43 100644
--- a/net/nqe/network_quality_estimator.cc
+++ b/net/nqe/network_quality_estimator.cc
@@ -1399,17 +1399,6 @@ bool NetworkQualityEstimator::ReadCachedNetworkQualityEstimate() {
const base::TimeTicks now = tick_clock_->NowTicks();
- if (effective_connection_type_ == EFFECTIVE_CONNECTION_TYPE_UNKNOWN) {
- // Read the effective connection type from the cached estimate.
- last_effective_connection_type_computation_ = now;
- network_quality_ = cached_network_quality.network_quality();
- effective_connection_type_ =
- cached_network_quality.effective_connection_type();
-
- if (effective_connection_type_ != EFFECTIVE_CONNECTION_TYPE_UNKNOWN)
- NotifyObserversOfEffectiveConnectionTypeChanged();
- }
-
if (cached_network_quality.network_quality().downstream_throughput_kbps() !=
nqe::internal::kInvalidThroughput) {
ThroughputObservation througphput_observation(
@@ -1439,6 +1428,7 @@ bool NetworkQualityEstimator::ReadCachedNetworkQualityEstimate() {
rtt_observations_.AddObservation(rtt_observation);
NotifyObserversOfRTT(rtt_observation);
}
+ ComputeEffectiveConnectionType();
return true;
}
« no previous file with comments | « no previous file | net/nqe/network_quality_estimator_params.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698