Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Unified Diff: net/nqe/network_quality_estimator.cc

Issue 2648353003: Add effective connection type to throughput mapping (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/nqe/network_quality_estimator.cc
diff --git a/net/nqe/network_quality_estimator.cc b/net/nqe/network_quality_estimator.cc
index 4950bef439455a9290f23e0bc4498969909ec820..d38e0bdfd75f74c76416697f3d2a9a15aaf78a90 100644
--- a/net/nqe/network_quality_estimator.cc
+++ b/net/nqe/network_quality_estimator.cc
@@ -1406,9 +1406,6 @@ bool NetworkQualityEstimator::ReadCachedNetworkQualityEstimate() {
network_quality_ = cached_network_quality.network_quality();
effective_connection_type_ =
cached_network_quality.effective_connection_type();
-
- if (effective_connection_type_ != EFFECTIVE_CONNECTION_TYPE_UNKNOWN)
- NotifyObserversOfEffectiveConnectionTypeChanged();
}
if (cached_network_quality.network_quality().downstream_throughput_kbps() !=
@@ -1440,6 +1437,7 @@ bool NetworkQualityEstimator::ReadCachedNetworkQualityEstimate() {
rtt_observations_.AddObservation(rtt_observation);
NotifyObserversOfRTT(rtt_observation);
}
+ ComputeEffectiveConnectionType();
RyanSturm 2017/01/25 19:15:34 If the computed type doesn't change from the ect o
tbansal1 2017/01/26 22:00:05 I removed that unnecessary code. ComputeECT() func
return true;
}
« no previous file with comments | « no previous file | net/nqe/network_quality_estimator_params.cc » ('j') | net/nqe/network_quality_estimator_params.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698