third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp - Issue 2648343004: Don't paint selections in <mask>s, <clipPath>s and <pattern>s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp

Issue 2648343004: Don't paint selections in <mask>s, <clipPath>s and <pattern>s (Closed)

Patch Set: Rebase Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/svg/text/selection-style-within-mask-crash-expected.txt ('k') | third_party/WebKit/Source/core/paint/PaintInfo.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp

index dbbcc326ba74973d1db61af9c6f3495c5a4e47eb..8a8220cc34d6bc3b8cb630a16703162152c6d9e4 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp

@@ -224,7 +224,8 @@ sk_sp<const SkPicture> LayoutSVGResourceClipper::createContentPicture() {

// - stroke is set to the initial stroke paint server (none)

PaintInfo info(pictureBuilder.context(), LayoutRect::infiniteIntRect(),

PaintPhaseForeground, GlobalPaintNormalPhase,

- PaintLayerPaintingRenderingClipPathAsMask);

+ PaintLayerPaintingRenderingClipPathAsMask |

+ PaintLayerPaintingRenderingResourceSubtree);

for (const SVGElement& childElement :

Traversal<SVGElement>::childrenOf(*element())) {