Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 264833004: Fix history on workspaces, where you couldn't click on old tries. (Closed)

Created:
6 years, 7 months ago by jcgregorio
Modified:
6 years, 7 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Fix history on workspaces, where you couldn't click on old tries. Also allow editing the first and last line because you might need to do that to fix "old" tries that are already stored in the database. By "old" I mean yesterday. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14516

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M experimental/webtry/res/js/webtry.js View 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jcgregorio
6 years, 7 months ago (2014-05-01 20:06:46 UTC) #1
f(malita)
lgtm
6 years, 7 months ago (2014-05-01 20:08:40 UTC) #2
jcgregorio
The CQ bit was checked by jcgregorio@google.com
6 years, 7 months ago (2014-05-01 20:08:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/264833004/1
6 years, 7 months ago (2014-05-01 20:09:09 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-01 20:17:22 UTC) #5
Message was sent while issue was closed.
Change committed as 14516

Powered by Google App Engine
This is Rietveld 408576698