Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Unified Diff: media/remoting/remote_renderer_impl.cc

Issue 2648303003: Media Remoting: Don't exit remoting if no enough data buffered. (Closed)
Patch Set: Addressed comments. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/remoting/remote_renderer_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/remoting/remote_renderer_impl.cc
diff --git a/media/remoting/remote_renderer_impl.cc b/media/remoting/remote_renderer_impl.cc
index f90ed1858ebad0b4b0b17b322a8648b9ad77ca95..07103c4d2212c612d923c58fd69f9900cea334c9 100644
--- a/media/remoting/remote_renderer_impl.cc
+++ b/media/remoting/remote_renderer_impl.cc
@@ -590,6 +590,13 @@ void RemoteRendererImpl::OnBufferingStateChange(
message->rendererclient_onbufferingstatechange_rpc().state());
if (!state.has_value())
return;
+ if (state == BufferingState::BUFFERING_HAVE_NOTHING) {
+ is_waiting_for_buffering_ = true;
+ } else if (is_waiting_for_buffering_) {
+ is_waiting_for_buffering_ = false;
+ ResetMeasurements();
+ }
+
client_->OnBufferingStateChange(state.value());
}
@@ -727,6 +734,8 @@ void RemoteRendererImpl::OnMediaTimeUpdated() {
DCHECK(media_task_runner_->BelongsToCurrentThread());
if (!flush_cb_.is_null())
return; // Don't manage and check the queue when Flush() is on-going.
+ if (is_waiting_for_buffering_)
+ return; // Don't manage and check the queue when buffering is on-going.
base::TimeTicks current_time = base::TimeTicks::Now();
if (current_time < ignore_updates_until_time_)
« no previous file with comments | « media/remoting/remote_renderer_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698